From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4270C47404 for ; Wed, 9 Oct 2019 15:57:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EF51206BB for ; Wed, 9 Oct 2019 15:57:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nsJ5KdbN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EF51206BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIEL2-0005Av-CT for qemu-devel@archiver.kernel.org; Wed, 09 Oct 2019 11:57:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42499) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iI17S-0001cR-By for qemu-devel@nongnu.org; Tue, 08 Oct 2019 21:50:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iI17Q-00083x-TC for qemu-devel@nongnu.org; Tue, 08 Oct 2019 21:50:26 -0400 Received: from mail-yb1-xb44.google.com ([2607:f8b0:4864:20::b44]:46152) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iI17Q-00083n-KI for qemu-devel@nongnu.org; Tue, 08 Oct 2019 21:50:24 -0400 Received: by mail-yb1-xb44.google.com with SMTP id h202so193037ybg.13 for ; Tue, 08 Oct 2019 18:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pRRGey9Kw0lIsuaYgixcsQ5RUwHu18e511yZ1VzoGaw=; b=nsJ5KdbNIcVTWQaU2tkP6YvmGjvcPYk83PN/BgJ59Esc9XlDWXPuQV03UngQUGUJSk Tew/2feqXzbb0XInqmCpK1iLfewqA25ui1H2Zexg6ew13yUjViG4OP/zGy9W3NbhkZw7 gfXnd9cEkdsxAhrHJm80/m0DvyguPmvoXxzkNk3WJqcPY38RM7g8JaON1ycBO2v6DNYX GG7sA0blF8C2acwtAgZL01qg79NsxSnS9UrTF2w4J6A0ZXaW8vpFiBc6T7MhMzLOEhCQ ScjRLJ2kwAewY09YqyNIRBYChl+jrga3t2pQM22+erQx9qTbsPEN6STmmLgvBEaSttXt dGBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pRRGey9Kw0lIsuaYgixcsQ5RUwHu18e511yZ1VzoGaw=; b=RxQd0+1EFwf+loLhb4Ca4ZB6z9mWrKakVaM6cU6bRLDn49OD8F1lTD54rfbpV03Cz6 Z8vkSeIIheMxWUlb7QUehV1WWAyva0KDP0ATZCbWNmKWwpD0g3Z3IiOs3fyIXgUurgxc Q2Kjb9ideQ8fSwe3v3qR9N6ZjWXXYx8nLXsCtjAP84fQR6bLrRSlj0J0JTf0yGssCjl2 VeKUC0QO75lc/kmr01KUFbUyldL0vaC0JeQV8G23RIkU9c4BT7EoEYL0Ji8fM7n/ic8h T5FOr5JOorAX8AOAZBWZy9MkkwVAZLva0M8GUlDzUDbhRqKpxKkpAN4pyRuDwhwEv4bQ M+yg== X-Gm-Message-State: APjAAAUjTYbRmPzjfbaoJxpYJfwGPLE0q4H7Yk0mTN4Ko8SyjpKnI8dV DQa25NZ/zW1CmICUB+oXL1DOlQ== X-Google-Smtp-Source: APXvYqzEYgmsq36EX7X32jrZH4wvrUiEF7He1CshtdsV1YkpCY3aBcdrBB7veECzGF9TtvV9uhFLUQ== X-Received: by 2002:a25:790a:: with SMTP id u10mr487573ybc.273.1570585823438; Tue, 08 Oct 2019 18:50:23 -0700 (PDT) Received: from [192.168.1.44] (67.216.144.16.pool.hargray.net. [67.216.144.16]) by smtp.gmail.com with ESMTPSA id g81sm199521ywa.46.2019.10.08.18.50.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Oct 2019 18:50:22 -0700 (PDT) Subject: Re: [PATCH v2 07/21] hw/timer/arm_mptimer.c: Switch to transaction-based ptimer API To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20191008171740.9679-1-peter.maydell@linaro.org> <20191008171740.9679-8-peter.maydell@linaro.org> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: Date: Tue, 8 Oct 2019 21:50:18 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191008171740.9679-8-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::b44 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/8/19 1:17 PM, Peter Maydell wrote: > Switch the arm_mptimer.c code away from bottom-half based ptimers to > the new transaction-based ptimer API. This just requires adding > begin/commit calls around the various places that modify the ptimer > state, and using the new ptimer_init() function to create the timer. > > Signed-off-by: Peter Maydell > --- > hw/timer/arm_mptimer.c | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~