qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] memory: Display MemoryRegion name in read/write ops trace events
Date: Mon, 7 Jun 2021 10:28:02 +0200	[thread overview]
Message-ID: <dadd0b69-e613-a0f6-5f81-a62159b41493@amsat.org> (raw)
In-Reply-To: <c4b050f9-8d36-28a5-b5fe-343bbbe0efdb@vivier.eu>

On 6/7/21 9:33 AM, Laurent Vivier wrote:
> Le 02/06/2021 à 12:49, Philippe Mathieu-Daudé a écrit :
>> Cc'ing qemu-trivial@
>>
>> On 3/18/21 4:39 PM, Philippe Mathieu-Daudé wrote:
>>> ping?
>>>
>>> On 3/7/21 8:48 AM, Philippe Mathieu-Daudé wrote:
>>>> MemoryRegion names is cached on first call to memory_region_name(),
> 
> It is cached on first call but now that it is used in the trace function, does it mean it will be
> always allocated in memory?

Yes, this is how memory_region_name() works:

const char *memory_region_name(const MemoryRegion *mr)
{
    if (!mr->name) {
        ((MemoryRegion *)mr)->name =
            g_strdup(object_get_canonical_path_component(OBJECT(mr)));
    }
    return mr->name;
}


> 
> Thanks,
> Laurent


  reply	other threads:[~2021-06-07  8:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-07  7:48 [PATCH] memory: Display MemoryRegion name in read/write ops trace events Philippe Mathieu-Daudé
2021-03-18 15:39 ` Philippe Mathieu-Daudé
2021-06-02 10:49   ` Philippe Mathieu-Daudé
2021-06-07  7:33     ` Laurent Vivier
2021-06-07  8:28       ` Philippe Mathieu-Daudé [this message]
2021-06-07 11:29         ` Laurent Vivier
2021-06-21 10:08           ` Philippe Mathieu-Daudé
2021-06-21 10:13             ` Laurent Vivier
2021-06-21 12:17               ` Philippe Mathieu-Daudé
2021-07-09  9:03                 ` Laurent Vivier
2021-06-05 19:26 ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dadd0b69-e613-a0f6-5f81-a62159b41493@amsat.org \
    --to=f4bug@amsat.org \
    --cc=laurent@vivier.eu \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).