From: Richard Henderson <richard.henderson@linaro.org>
To: Michal Privoznik <mprivozn@redhat.com>, qemu-devel@nongnu.org
Cc: vfeenstr@redhat.com, mdroth@linux.vnet.ibm.com
Subject: Re: [PATCH] qga: Use gethostname() instead of g_get_host_name()
Date: Fri, 19 Jun 2020 14:54:10 -0700 [thread overview]
Message-ID: <dae9555b-f9f1-37d1-5c42-f64bf448d73e@linaro.org> (raw)
In-Reply-To: <8e73f685e10c684eb5e2c88c2185504d26f024fc.1592296355.git.mprivozn@redhat.com>
On 6/16/20 1:34 AM, Michal Privoznik wrote:
> +#ifndef G_OS_WIN32
Nit: positive tests are easier to reason with and extend than negative tests.
I would reverse these two blocks and use a positive test for windows.
Also, CONFIG_WIN32 is what we use elsewhere for this test.
r~
next prev parent reply other threads:[~2020-06-19 21:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 8:34 [PATCH] qga: Use gethostname() instead of g_get_host_name() Michal Privoznik
2020-06-16 8:43 ` Marc-André Lureau
2020-06-19 21:54 ` Richard Henderson [this message]
2020-06-22 10:06 ` Michal Privoznik
2020-06-22 10:14 ` Philippe Mathieu-Daudé
2020-06-22 13:08 ` Michal Privoznik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dae9555b-f9f1-37d1-5c42-f64bf448d73e@linaro.org \
--to=richard.henderson@linaro.org \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vfeenstr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).