From: John Snow <jsnow@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] tests/hd-geo-test: Don't pass NULL to unlink()
Date: Tue, 6 Sep 2016 15:15:38 -0400 [thread overview]
Message-ID: <daf8d4f9-d497-b8fc-8b82-9b642188b030@redhat.com> (raw)
In-Reply-To: <CAFEAcA-sRz4D4O8Su+zdaXPo=O8Ce_DQecFtE_zmkzXwGviDVg@mail.gmail.com>
On 09/06/2016 03:07 PM, Peter Maydell wrote:
> On 6 September 2016 at 20:06, John Snow <jsnow@redhat.com> wrote:
>> On 09/06/2016 08:47 AM, Peter Maydell wrote:
>>>
>>> Ping?
>
>> Not sure who this belongs to; I can queue it up alongside some IDE and FDC
>> stuff in the future if you like.
>
> I can apply it directly; I'd just like review :-)
>
lol! yes, of course you can...
> thanks
> -- PMM
>
Well, I know some have religious arguments against making sanitizers
happy, but that's not my religion.
If some systems appear to think that unlink must take a nonnull
argument, I think that's a bug -- but making the sanitizer happy doesn't
cost us much either IMO.
(And it's /just/ a test.)
So, personally:
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2016-09-06 19:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 10:03 [Qemu-devel] [PATCH] tests/hd-geo-test: Don't pass NULL to unlink() Peter Maydell
2016-08-05 11:19 ` Markus Armbruster
2016-08-05 11:57 ` Peter Maydell
2016-09-06 12:47 ` Peter Maydell
2016-09-06 19:06 ` John Snow
2016-09-06 19:07 ` Peter Maydell
2016-09-06 19:15 ` John Snow [this message]
2016-09-06 19:52 ` Peter Maydell
2016-09-08 10:27 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daf8d4f9-d497-b8fc-8b82-9b642188b030@redhat.com \
--to=jsnow@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).