From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47810) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhLqR-0007mR-TG for qemu-devel@nongnu.org; Tue, 06 Sep 2016 15:15:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhLqN-0006yq-KY for qemu-devel@nongnu.org; Tue, 06 Sep 2016 15:15:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhLqN-0006yi-F5 for qemu-devel@nongnu.org; Tue, 06 Sep 2016 15:15:39 -0400 References: <1470391392-28274-1-git-send-email-peter.maydell@linaro.org> <4f213302-3457-d060-3f84-f16c14087f0c@redhat.com> From: John Snow Message-ID: Date: Tue, 6 Sep 2016 15:15:38 -0400 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tests/hd-geo-test: Don't pass NULL to unlink() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Patch Tracking On 09/06/2016 03:07 PM, Peter Maydell wrote: > On 6 September 2016 at 20:06, John Snow wrote: >> On 09/06/2016 08:47 AM, Peter Maydell wrote: >>> >>> Ping? > >> Not sure who this belongs to; I can queue it up alongside some IDE and FDC >> stuff in the future if you like. > > I can apply it directly; I'd just like review :-) > lol! yes, of course you can... > thanks > -- PMM > Well, I know some have religious arguments against making sanitizers happy, but that's not my religion. If some systems appear to think that unlink must take a nonnull argument, I think that's a bug -- but making the sanitizer happy doesn't cost us much either IMO. (And it's /just/ a test.) So, personally: Reviewed-by: John Snow