From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fT6El-0001mF-Ta for qemu-devel@nongnu.org; Wed, 13 Jun 2018 09:55:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fT6Ei-00037W-Gu for qemu-devel@nongnu.org; Wed, 13 Jun 2018 09:54:59 -0400 References: <1528866321-23886-1-git-send-email-thuth@redhat.com> <1528866321-23886-2-git-send-email-thuth@redhat.com> <540abc07-2b96-bf0b-6f5a-2a4efc5184d9@redhat.com> From: Paolo Bonzini Message-ID: Date: Wed, 13 Jun 2018 15:54:49 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] Replace '-machine accel=xyz' with '-accel xyz' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Eduardo Habkost , Ben Warren , zhang.zhanghailiang@huawei.com, Markus Armbruster , qemu-trivial@nongnu.org On 13/06/2018 14:53, Thomas Huth wrote: > On 13.06.2018 14:48, Paolo Bonzini wrote: >> On 13/06/2018 07:05, Thomas Huth wrote: >>> diff --git a/tests/vmgenid-test.c b/tests/vmgenid-test.c >>> index 8d915c6..4324034 100644 >>> --- a/tests/vmgenid-test.c >>> +++ b/tests/vmgenid-test.c >>> @@ -131,7 +131,7 @@ static void read_guid_from_monitor(QemuUUID *guid) >>> static char disk[] = "tests/vmgenid-test-disk-XXXXXX"; >>> >>> #define GUID_CMD(guid) \ >>> - "-machine accel=kvm:tcg " \ >>> + "-accel kvm:tcg " \ >>> "-device vmgenid,id=testvgid,guid=%s " \ >> >> "-accel kvm:tcg" works, but it really shouldn't (and I think we can >> change it without a deprecation period). The right syntax would be >> "-accel kvm -accel tcg", so that you can specify options that are valid >> only for KVM, or onlty for TCG. > > I see your point, but this would break these qtests that are trying to > override the "-machine accel=qtest" from libqtest.c this way... The solution would be to put "-accel kvm -accel tcg" before "-accel qtest". > and if > any other tool out there in the wild is already depending on this > behavior, too, we can not change it so easily anymore. I think -accel is new and obscure enough that it's unlikely to be used with a colon. In my opinion, the risk is worth the benefit of finally getting a proper interface for accelerators. Paolo