From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw/input/tsc210x: Fix building with no verbosity
Date: Tue, 5 Feb 2019 04:25:50 +0100 [thread overview]
Message-ID: <db084f78-35f8-cc5f-4bf6-ffdcdce326bc@redhat.com> (raw)
In-Reply-To: <20190204204517.23698-1-philmd@redhat.com>
On 2019-02-04 21:45, Philippe Mathieu-Daudé wrote:
> When building with TSC_VERBOSE not defined, we get:
> CC arm-softmmu/hw/input/tsc210x.o
> hw/input/tsc210x.c: In function ‘tsc2102_data_register_write’:
> hw/input/tsc210x.c:554:5: error: label at end of compound statement
> default:
> ^~~~~~~
> hw/input/tsc210x.c: In function ‘tsc2102_control_register_write’:
> hw/input/tsc210x.c:638:5: error: label at end of compound statement
> bad_reg:
> ^~~~~~~
> hw/input/tsc210x.c: In function ‘tsc2102_audio_register_write’:
> hw/input/tsc210x.c:766:5: error: label at end of compound statement
> default:
> ^~~~~~~
> make[1]: *** [rules.mak:69: hw/input/tsc210x.o] Error 1
>
> Fix this by replacing the culprit fprintf(stderr) calls by a more
> recent API: qemu_log_mask(LOG_GUEST_ERROR). Other fprintf() calls
> are left untouched.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/input/tsc210x.c | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2019-02-05 3:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 20:45 [Qemu-devel] [PATCH] hw/input/tsc210x: Fix building with no verbosity Philippe Mathieu-Daudé
2019-02-04 20:49 ` no-reply
2019-02-04 23:32 ` Philippe Mathieu-Daudé
2019-02-05 3:25 ` Thomas Huth [this message]
2019-02-06 9:23 ` Stefano Garzarella
2019-02-06 14:57 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db084f78-35f8-cc5f-4bf6-ffdcdce326bc@redhat.com \
--to=thuth@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).