From: Eric Blake <eblake@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Fam Zheng" <famz@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 for-2.11] Makefile: use $(MAKE) variable
Date: Tue, 21 Nov 2017 06:17:41 -0600 [thread overview]
Message-ID: <db0b9556-1758-874d-0194-2b77f09173f0@redhat.com> (raw)
In-Reply-To: <20171121095510.29436-1-f4bug@amsat.org>
[-- Attachment #1: Type: text/plain, Size: 746 bytes --]
On 11/21/2017 03:55 AM, Philippe Mathieu-Daudé wrote:
> For some systems (i.e. FreeBSD) the default 'make' is not compatible with the
> GNU extensions used by QEMU makefiles.
>
> Calling the GNU make (gmake) works, however the help displayed refers to the
> host 'make' and copy/paste leads to lot of unobvious errors:
>
>
> Using the $(MAKE) variable, the help displayed is consistent with the 'make'
> program used.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> v2: dropped inconsistent replace in comment (Fam's review)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
prev parent reply other threads:[~2017-11-21 12:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 9:55 [Qemu-devel] [PATCH v2 for-2.11] Makefile: use $(MAKE) variable Philippe Mathieu-Daudé
2017-11-21 12:17 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db0b9556-1758-874d-0194-2b77f09173f0@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).