From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20757C4361B for ; Wed, 16 Dec 2020 15:43:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5C4B22DBF for ; Wed, 16 Dec 2020 15:43:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5C4B22DBF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54764 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpYx9-0004E6-KX for qemu-devel@archiver.kernel.org; Wed, 16 Dec 2020 10:42:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpYfz-0005p9-IP for qemu-devel@nongnu.org; Wed, 16 Dec 2020 10:25:16 -0500 Received: from mail-oi1-x235.google.com ([2607:f8b0:4864:20::235]:37801) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpYfu-0006gt-A5 for qemu-devel@nongnu.org; Wed, 16 Dec 2020 10:25:15 -0500 Received: by mail-oi1-x235.google.com with SMTP id l207so27906663oib.4 for ; Wed, 16 Dec 2020 07:25:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Kzs6N7vPIGjHsPFBWcJpGYTind6XbEBvmk85TtJ8few=; b=mPvhtLnilo+vP9OfVkyypVXuaf8iTm1OCCVZQjASJQIco0CVDdFqnldeOUGlcTclrV OMis2bAWhQc++Ojufwjylp3YKdgXP2NogaBb8HR/D+Ru2CjLIRS9MozWMeqWycYxfwXH JtWSE3aeZbzpI2HvNLzk4wd0nGJGFRkyZvEQt9058BpvVQtL9jfj5ZMguyMkaDAltHHC k8kDtiYVMrIjaueOPnV0Prh+Jtd7vOg5Zp6fnJ7xhxCQXeYaICYujJqteP/vBeCqd84P FMpbchaJ7ybgne/REZW9tH194kjuDwbvPJoXNYFdIDY269bHQL5trzSdxqSj9t2zQRW0 5aPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Kzs6N7vPIGjHsPFBWcJpGYTind6XbEBvmk85TtJ8few=; b=m8UmR0ZtKCwwBd+DIPIynzcndw9Gc8JVYR3BSrDU8MdQDGI+4N2Y+xHo9pqJPGZqF1 a/IU9h5zMyKq6aUuCr1l84qWnqmSzIE91xoDsaQI83dkw6BpwgpHXccjmJ0daZOm4Er8 AQr+2pw7zOF/PPWVVw4p4qCJ1ZoD1jDpC7CpprAZoXN1fGceSQWxcrQVI4BXjHynqcRl 5wi36DZRxg15w9eEKBCzsTnHfHS6rFuaaggJO4bSppcrB9O49v+t6OlvLfGO7bDiE9aQ 1GGw5SBf4S0dlVuIuDrJ5Z2KL8QE1YSFh2QicOP9JXbZ81Brs6idIJiFxCEgdXU9mW56 o8Jw== X-Gm-Message-State: AOAM532bvkVk3eF3zEKG86hgv1t00mLQEmzn2EMd3TCLOGPeGnYyIdBa TwE8qJlBdOuk8LyEMzNIGU+xAA== X-Google-Smtp-Source: ABdhPJwZeoPo9x8omx+s81/54cyOuzAHHrczEqi/4LBb31/NEc+YbqFYrgBCMYpFAXLQ2fhSxkv3Ug== X-Received: by 2002:aca:b506:: with SMTP id e6mr2278535oif.119.1608132308042; Wed, 16 Dec 2020 07:25:08 -0800 (PST) Received: from [10.10.121.52] (fixed-187-189-51-144.totalplay.net. [187.189.51.144]) by smtp.gmail.com with ESMTPSA id 30sm490279oth.7.2020.12.16.07.25.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Dec 2020 07:25:07 -0800 (PST) Subject: Re: [RFC v2 04/15] target/riscv: rvb: logic-with-negate To: frank.chang@sifive.com, qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <20201216020150.3157-1-frank.chang@sifive.com> <20201216020150.3157-5-frank.chang@sifive.com> From: Richard Henderson Message-ID: Date: Wed, 16 Dec 2020 09:25:04 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201216020150.3157-5-frank.chang@sifive.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::235; envelope-from=richard.henderson@linaro.org; helo=mail-oi1-x235.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , Kito Cheng , Alistair Francis , Palmer Dabbelt , Sagar Karandikar Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/15/20 8:01 PM, frank.chang@sifive.com wrote: > +static void gen_andn(TCGv ret, TCGv arg1, TCGv arg2) > +{ > + TCGv t = tcg_temp_new(); > + tcg_gen_andc_tl(ret, arg1, arg2); > + tcg_temp_free(t); > +} > + > +static void gen_orn(TCGv ret, TCGv arg1, TCGv arg2) > +{ > + TCGv t = tcg_temp_new(); > + tcg_gen_orc_tl(ret, arg1, arg2); > + tcg_temp_free(t); > +} > + > +static void gen_xnor(TCGv ret, TCGv arg1, TCGv arg2) > +{ > + TCGv t = tcg_temp_new(); > + tcg_gen_eqv_tl(ret, arg1, arg2); > + tcg_temp_free(t); > +} Drop these functions entirely, along with their unused temporaries. r~