From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Liran Alon <liran.alon@oracle.com>
Cc: pbonzini@redhat.com, Bhavesh Davda <bhavesh.davda@oracle.com>,
qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [PATCH] configure: Fix pkg_config --exists parameter
Date: Wed, 4 Mar 2020 20:05:04 +0100 [thread overview]
Message-ID: <db262208-f61d-e8e5-c9e1-a87fb34f1fc3@redhat.com> (raw)
In-Reply-To: <20200304174217.GI4104@work-vm>
On 3/4/20 6:42 PM, Dr. David Alan Gilbert wrote:
> * Liran Alon (liran.alon@oracle.com) wrote:
>> pkg_config parameter should be "--exists", not "--exist".
>> This is probably a typo.
>>
>> Fixes: 3a67848134d0 ("configure: Enable test and libs for zstd")
>> Reviewed-by: Bhavesh Davda <bhavesh.davda@oracle.com>
>> Signed-off-by: Liran Alon <liran.alon@oracle.com>
>
> That's the same as 20200303124925.28079-1-dplotnikov@virtuozzo.com from
> Denis yesterday.
And Alex 2 days ago:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg684754.html
>
> Dave
>
>> ---
>> configure | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 50c4d96e2a8c..280f3654f786 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2464,7 +2464,7 @@ fi
>> # zstd check
>>
>> if test "$zstd" != "no" ; then
>> - if $pkg_config --exist libzstd ; then
>> + if $pkg_config --exists libzstd ; then
>> zstd_cflags="$($pkg_config --cflags libzstd)"
>> zstd_libs="$($pkg_config --libs libzstd)"
>> LIBS="$zstd_libs $LIBS"
>> --
>> 2.20.1
>>
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
>
>
prev parent reply other threads:[~2020-03-04 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 17:41 [PATCH] configure: Fix pkg_config --exists parameter Liran Alon
2020-03-04 17:42 ` Dr. David Alan Gilbert
2020-03-04 19:05 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db262208-f61d-e8e5-c9e1-a87fb34f1fc3@redhat.com \
--to=philmd@redhat.com \
--cc=bhavesh.davda@oracle.com \
--cc=dgilbert@redhat.com \
--cc=liran.alon@oracle.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).