From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, Michael Tsirkin <mst@redhat.com>,
qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [PATCH] meson: Clarify the confusing vhost-user vs. vhost-kernel output
Date: Mon, 9 Nov 2020 10:09:42 +0100 [thread overview]
Message-ID: <db279473-2610-8599-100f-a7fdf3fc22a4@redhat.com> (raw)
In-Reply-To: <20201109085906.87921-1-thuth@redhat.com>
On 09/11/20 09:59, Thomas Huth wrote:
> The configuration summary prints a line with "vhost-user: YES/NO",
> but the value is currently the vhost-kernel setting instead which
> looks wrong. Print the kernel setting in a separate line and switch
> the "vhost-user:" line to CONFIG_VHOST_USER instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> meson.build | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index b473620321..61d883bc07 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2098,11 +2098,12 @@ summary_info += {'madvise': config_host.has_key('CONFIG_MADVISE')}
> summary_info += {'posix_madvise': config_host.has_key('CONFIG_POSIX_MADVISE')}
> summary_info += {'posix_memalign': config_host.has_key('CONFIG_POSIX_MEMALIGN')}
> summary_info += {'libcap-ng support': config_host.has_key('CONFIG_LIBCAP_NG')}
> +summary_info += {'vhost-kernel support': config_host.has_key('CONFIG_VHOST_KERNEL')}
> summary_info += {'vhost-net support': config_host.has_key('CONFIG_VHOST_NET')}
> summary_info += {'vhost-crypto support': config_host.has_key('CONFIG_VHOST_CRYPTO')}
> summary_info += {'vhost-scsi support': config_host.has_key('CONFIG_VHOST_SCSI')}
> summary_info += {'vhost-vsock support': config_host.has_key('CONFIG_VHOST_VSOCK')}
> -summary_info += {'vhost-user support': config_host.has_key('CONFIG_VHOST_KERNEL')}
> +summary_info += {'vhost-user support': config_host.has_key('CONFIG_VHOST_USER')}
> summary_info += {'vhost-user-fs support': config_host.has_key('CONFIG_VHOST_USER_FS')}
> summary_info += {'vhost-vdpa support': config_host.has_key('CONFIG_VHOST_VDPA')}
> summary_info += {'Trace backends': config_host['TRACE_BACKENDS']}
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2020-11-09 9:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 8:59 [PATCH] meson: Clarify the confusing vhost-user vs. vhost-kernel output Thomas Huth
2020-11-09 9:09 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db279473-2610-8599-100f-a7fdf3fc22a4@redhat.com \
--to=pbonzini@redhat.com \
--cc=f4bug@amsat.org \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).