* [PATCH] meson: Clarify the confusing vhost-user vs. vhost-kernel output
@ 2020-11-09 8:59 Thomas Huth
2020-11-09 9:09 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2020-11-09 8:59 UTC (permalink / raw)
To: Paolo Bonzini, Michael Tsirkin, qemu-devel
Cc: Marc-André Lureau, Philippe Mathieu-Daudé,
Stefan Hajnoczi
The configuration summary prints a line with "vhost-user: YES/NO",
but the value is currently the vhost-kernel setting instead which
looks wrong. Print the kernel setting in a separate line and switch
the "vhost-user:" line to CONFIG_VHOST_USER instead.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index b473620321..61d883bc07 100644
--- a/meson.build
+++ b/meson.build
@@ -2098,11 +2098,12 @@ summary_info += {'madvise': config_host.has_key('CONFIG_MADVISE')}
summary_info += {'posix_madvise': config_host.has_key('CONFIG_POSIX_MADVISE')}
summary_info += {'posix_memalign': config_host.has_key('CONFIG_POSIX_MEMALIGN')}
summary_info += {'libcap-ng support': config_host.has_key('CONFIG_LIBCAP_NG')}
+summary_info += {'vhost-kernel support': config_host.has_key('CONFIG_VHOST_KERNEL')}
summary_info += {'vhost-net support': config_host.has_key('CONFIG_VHOST_NET')}
summary_info += {'vhost-crypto support': config_host.has_key('CONFIG_VHOST_CRYPTO')}
summary_info += {'vhost-scsi support': config_host.has_key('CONFIG_VHOST_SCSI')}
summary_info += {'vhost-vsock support': config_host.has_key('CONFIG_VHOST_VSOCK')}
-summary_info += {'vhost-user support': config_host.has_key('CONFIG_VHOST_KERNEL')}
+summary_info += {'vhost-user support': config_host.has_key('CONFIG_VHOST_USER')}
summary_info += {'vhost-user-fs support': config_host.has_key('CONFIG_VHOST_USER_FS')}
summary_info += {'vhost-vdpa support': config_host.has_key('CONFIG_VHOST_VDPA')}
summary_info += {'Trace backends': config_host['TRACE_BACKENDS']}
--
2.18.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] meson: Clarify the confusing vhost-user vs. vhost-kernel output
2020-11-09 8:59 [PATCH] meson: Clarify the confusing vhost-user vs. vhost-kernel output Thomas Huth
@ 2020-11-09 9:09 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2020-11-09 9:09 UTC (permalink / raw)
To: Thomas Huth, Michael Tsirkin, qemu-devel
Cc: Marc-André Lureau, Philippe Mathieu-Daudé,
Stefan Hajnoczi
On 09/11/20 09:59, Thomas Huth wrote:
> The configuration summary prints a line with "vhost-user: YES/NO",
> but the value is currently the vhost-kernel setting instead which
> looks wrong. Print the kernel setting in a separate line and switch
> the "vhost-user:" line to CONFIG_VHOST_USER instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> meson.build | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index b473620321..61d883bc07 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2098,11 +2098,12 @@ summary_info += {'madvise': config_host.has_key('CONFIG_MADVISE')}
> summary_info += {'posix_madvise': config_host.has_key('CONFIG_POSIX_MADVISE')}
> summary_info += {'posix_memalign': config_host.has_key('CONFIG_POSIX_MEMALIGN')}
> summary_info += {'libcap-ng support': config_host.has_key('CONFIG_LIBCAP_NG')}
> +summary_info += {'vhost-kernel support': config_host.has_key('CONFIG_VHOST_KERNEL')}
> summary_info += {'vhost-net support': config_host.has_key('CONFIG_VHOST_NET')}
> summary_info += {'vhost-crypto support': config_host.has_key('CONFIG_VHOST_CRYPTO')}
> summary_info += {'vhost-scsi support': config_host.has_key('CONFIG_VHOST_SCSI')}
> summary_info += {'vhost-vsock support': config_host.has_key('CONFIG_VHOST_VSOCK')}
> -summary_info += {'vhost-user support': config_host.has_key('CONFIG_VHOST_KERNEL')}
> +summary_info += {'vhost-user support': config_host.has_key('CONFIG_VHOST_USER')}
> summary_info += {'vhost-user-fs support': config_host.has_key('CONFIG_VHOST_USER_FS')}
> summary_info += {'vhost-vdpa support': config_host.has_key('CONFIG_VHOST_VDPA')}
> summary_info += {'Trace backends': config_host['TRACE_BACKENDS']}
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-09 9:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-09 8:59 [PATCH] meson: Clarify the confusing vhost-user vs. vhost-kernel output Thomas Huth
2020-11-09 9:09 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).