Re: [Qemu-devel] [PATCH v7 10/35] target/riscv: Convert RV32A insns to decodetree

[Bastian Koppelmann <kbastian@mail.uni-paderborn.de>]

On 2/13/19 4:53 PM, Palmer Dabbelt wrote:
> From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
>
> Acked-by: Alistair Francis <alistair.francis@wdc.com>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> Signed-off-by: Peer Adelt <peer.adelt@hni.uni-paderborn.de>
> ---
>   target/riscv/insn32.decode              |  17 +++
>   target/riscv/insn_trans/trans_rva.inc.c | 149 ++++++++++++++++++++++++
>   target/riscv/translate.c                |   1 +
>   3 files changed, 167 insertions(+)
>   create mode 100644 target/riscv/insn_trans/trans_rva.inc.c
>
> diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode
> index e53944bf0e40..00b9e2d9a508 100644
> --- a/target/riscv/insn32.decode
> +++ b/target/riscv/insn32.decode


All translate_foo() functions are missing 'if (!has_ext(ctx, RVA)) 
return false'

Cheers,

Bastian