From: Jason Wang <jasowang@redhat.com>
To: Vikram Garhwal <fnuv@xilinx.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH 0/1] Introduce Xlnx ZynqMP CAN controller for QEMU
Date: Wed, 5 Feb 2020 13:48:24 +0800 [thread overview]
Message-ID: <db517307-30b0-7099-1f7c-bcc3e40fec80@redhat.com> (raw)
In-Reply-To: <BYAPR02MB563811B646F102BB37293F9FBC020@BYAPR02MB5638.namprd02.prod.outlook.com>
On 2020/2/5 上午11:23, Vikram Garhwal wrote:
> Hi Jason,
> Yes, I will maintain this NIC. Thanks for the help.
>
> Regards,
> Vikram
Good to know that.
Please update MAINTINERS and it would be better if you can draft a qtest
for this NIC.
I leave some quick comments for the patch and I hope the patch could be
reviewed by others as well.
Thanks
>
>> -----Original Message-----
>> From: Jason Wang <jasowang@redhat.com>
>> Sent: Tuesday, February 4, 2020 7:17 PM
>> To: Vikram Garhwal <fnuv@xilinx.com>; qemu-devel@nongnu.org
>> Subject: Re: [PATCH 0/1] Introduce Xlnx ZynqMP CAN controller for QEMU
>>
>>
>> On 2020/2/4 上午5:06, Vikram Garhwal wrote:
>>> Example for single CAN:
>>> -object can-bus,id=canbus0 \
>>> -global driver=xlnx.zynqmp-can,property=canbus0,value=canbus0 \
>>> -object can-host-socketcan,id=socketcan0,if=vcan0,canbus=canbus0
>>>
>>> Example for connecting both CAN:
>>> -object can-bus,id=canbus0 -object can-bus,id=canbus1 \
>>> -global driver=xlnx.zynqmp-can,property=canbus0,value=canbus0 \
>>> -global driver=xlnx.zynqmp-can,property=canbus1,value=canbus1 \
>>> -object can-host-socketcan,id=socketcan0,if=vcan0,canbus=canbus0 \
>>> -object can-host-socketcan,id=socketcan1,if=vcan0,canbus=canbus1
>>>
>>> Vikram Garhwal (1):
>>> hw/net/can: Introduce Xlnx ZynqMP CAN controller for QEMU
>>>
>>> hw/net/can/Makefile.objs | 1 +
>>> hw/net/can/xlnx-zynqmp-can.c | 1106
>> ++++++++++++++++++++++++++++++++++++++
>>> include/hw/net/xlnx-zynqmp-can.h | 77 +++
>>> 3 files changed, 1184 insertions(+)
>>> create mode 100644 hw/net/can/xlnx-zynqmp-can.c
>>> create mode 100644 include/hw/net/xlnx-zynqmp-can.h
>>>
>> Hi Vikram:
>>
>> I would like to confirm that whether or not you would maintain this NIC.
>> (I think the answer is yes). I tend not to merge a NIC model without a
>> maintainer.
>>
>> Thanks
prev parent reply other threads:[~2020-02-05 5:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 21:06 [PATCH 0/1] Introduce Xlnx ZynqMP CAN controller for QEMU Vikram Garhwal
2020-02-03 21:06 ` [PATCH 1/1] hw/net/can: " Vikram Garhwal
2020-02-05 5:46 ` Jason Wang
2020-02-06 18:39 ` Vikram Garhwal
2020-02-10 21:45 ` Vikram Garhwal
2020-02-11 3:09 ` Jason Wang
2020-02-25 6:22 ` Vikram Garhwal
2020-02-26 3:24 ` Jason Wang
2020-02-27 16:04 ` Vikram Garhwal
2020-02-05 3:17 ` [PATCH 0/1] " Jason Wang
2020-02-05 3:23 ` Vikram Garhwal
2020-02-05 5:48 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db517307-30b0-7099-1f7c-bcc3e40fec80@redhat.com \
--to=jasowang@redhat.com \
--cc=fnuv@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).