From: David Woodhouse <dwmw2@infradead.org>
To: Roger Pau Monne <roger.pau@citrix.com>, qemu-devel@nongnu.org
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Anthony PERARD" <anthony@xenproject.org>,
"Paul Durrant" <paul@xen.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
xen-devel@lists.xenproject.org, qemu-block@nongnu.org
Subject: Re: [PATCH v2 2/2] xen: do not use '%ms' scanf specifier
Date: Fri, 10 Jan 2025 09:55:57 +0000 [thread overview]
Message-ID: <db708ce428d6047b1761d2d11fb25acc8af353a9.camel@infradead.org> (raw)
In-Reply-To: <20250110093531.23221-3-roger.pau@citrix.com>
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
On Fri, 2025-01-10 at 10:35 +0100, Roger Pau Monne wrote:
> The 'm' parameter used to request auto-allocation of the destination variable
> is not supported on FreeBSD, and as such leads to failures to parse.
>
> What's more, the current usage of '%ms' with xs_node_scanf() is pointless, as
> it just leads to a double allocation of the same string. Instead use
> xs_node_read() to read the whole xenstore node.
>
> Fixes: a783f8ad4ec9 ('xen: add a mechanism to automatically create XenDevice-s...')
> Fixes: 9b7737469080 ('hw/xen: update Xen console to XenDevice model')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
Thanks.
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5069 bytes --]
next prev parent reply other threads:[~2025-01-10 9:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 9:35 [PATCH v2 0/2] xen: error handling and FreeBSD compatibility fixes Roger Pau Monne
2025-01-10 9:35 ` [PATCH v2 1/2] hw/xen: Add xs_node_read() helper function Roger Pau Monne
2025-01-10 10:01 ` Philippe Mathieu-Daudé
2025-01-15 14:07 ` Anthony PERARD
2025-01-10 9:35 ` [PATCH v2 2/2] xen: do not use '%ms' scanf specifier Roger Pau Monne
2025-01-10 9:55 ` David Woodhouse [this message]
2025-01-15 14:36 ` Anthony PERARD
2025-01-15 16:04 ` David Woodhouse
2025-01-10 10:02 ` [PATCH v2 0/2] xen: error handling and FreeBSD compatibility fixes David Woodhouse
2025-01-10 10:03 ` [PATCH 1/4] hw/xen: Use xs_node_read() from xs_node_vscanf() David Woodhouse
2025-01-10 10:03 ` [PATCH 2/4] hw/xen: Use xs_node_read() from xen_console_get_name() David Woodhouse
2025-01-15 14:56 ` Anthony PERARD
2025-01-10 10:03 ` [PATCH 3/4] hw/xen: Use xs_node_read() from xen_netdev_get_name() David Woodhouse
2025-01-15 14:59 ` Anthony PERARD
2025-01-10 10:03 ` [PATCH 4/4] hw/xen: Use xs_node_read() from xenstore_read_str() instead of open-coding it David Woodhouse
2025-01-15 15:05 ` Anthony PERARD
2025-01-15 14:56 ` [PATCH 1/4] hw/xen: Use xs_node_read() from xs_node_vscanf() Anthony PERARD
2025-01-15 14:34 ` [PATCH v2 0/2] xen: error handling and FreeBSD compatibility fixes Roger Pau Monné
2025-01-15 14:36 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db708ce428d6047b1761d2d11fb25acc8af353a9.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=anthony@xenproject.org \
--cc=edgar.iglesias@gmail.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).