From: Yi Min Zhao <zyimin@linux.vnet.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>,
QingFeng Hao <haoqf@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, mreitz@redhat.com, qemu-block@nongnu.org,
qemu-devel@nongnu.org, borntraeger@de.ibm.com, agraf@suse.de,
thuth@redhat.com, david@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/3] iotests: cure s390x failures by switching to ccw
Date: Wed, 6 Sep 2017 16:09:27 +0800 [thread overview]
Message-ID: <db715440-ebe4-1362-acf5-60e5a45491ee@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170906095953.13d5fb01.cohuck@redhat.com>
在 2017/9/6 下午3:59, Cornelia Huck 写道:
> On Wed, 6 Sep 2017 14:57:48 +0800
> QingFeng Hao <haoqf@linux.vnet.ibm.com> wrote:
>
>> 在 2017/9/5 23:16, Cornelia Huck 写道:
>>> Recent changes in s390x made pci support dependant on the zpci cpu
>>> feature, which is not provided on all models (and not on by default).
>>> This means we cannot instatiate pci devices on a standard qemu
>>> invocation for s390x. Moreover, the zpci instructions are not even
>>> wired up for tcg yet, so actually doing anything with those pci devices
>>> is bound to fail on tcg.
>>>
>>> Let's follow the existing example in 068 and switch to the (default)
>>> virtio-ccw transport on s390x. The changes for 051 and 067 are split
>>> out as they require adding an output file for s390x (the actual command
>>> lines are part of the output).
>> We also found this error and YiMin suggested to change the code in ccw_init
>> as below:
>>
>> if (pci_available) {
>> DeviceState *dev = qdev_create(NULL, TYPE_S390_PCI_HOST_BRIDGE);
>> ...
>> }
>> We tested it and it can make the 5 cases passed.
> OK, looked at this. This won't work: pci_available means "this qemu has
> pci support built in". _Working_ zpci, however, depends on the presence
> of the zpci feature bit: You'll have a host bridge and can define
> devices that have absolutely no chance of working, since all pci
> instruction will return errors. You will be in a similar situation
> under kvm as under tcg: you can specify virtio-pci devices on the
> command line, but they can't work.
Oh. Yes, that makes sense. Actually the first way we thought about was
change the code
not change the testcases. Thanks for your work.
>
> This probably makes the 5 cases pass as they only rely on the ability
> to create the device, not to do anything with them.
>
> So, I still think the right thing to do is to switch to ccw in the
> tests (and to wire up pci in tcg, but that's an orthogonal issue).
Agree.
>
>
prev parent reply other threads:[~2017-09-06 8:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 15:16 [Qemu-devel] [PATCH 0/3] iotests: cure s390x failures by switching to ccw Cornelia Huck
2017-09-05 15:16 ` [Qemu-devel] [PATCH 1/3] iotests: use -ccw on s390x for 040, 139, and 182 Cornelia Huck
2017-09-08 11:07 ` Kevin Wolf
2017-09-05 15:16 ` [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051 Cornelia Huck
2017-09-06 7:19 ` QingFeng Hao
2017-09-06 7:32 ` Cornelia Huck
2017-09-06 8:42 ` QingFeng Hao
2017-09-08 11:04 ` Kevin Wolf
2017-09-08 11:24 ` Cornelia Huck
2017-09-08 11:54 ` Kevin Wolf
2017-09-08 15:55 ` Thomas Huth
2017-09-11 10:29 ` Lukáš Doktor
2017-09-12 16:05 ` Cornelia Huck
2017-09-12 16:16 ` Kevin Wolf
2017-09-05 15:16 ` [Qemu-devel] [PATCH 3/3] iotests: use -ccw on s390x for 067 Cornelia Huck
2017-09-08 11:06 ` Kevin Wolf
2017-09-06 6:57 ` [Qemu-devel] [PATCH 0/3] iotests: cure s390x failures by switching to ccw QingFeng Hao
2017-09-06 7:17 ` Cornelia Huck
2017-09-06 7:59 ` Cornelia Huck
2017-09-06 8:09 ` Yi Min Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db715440-ebe4-1362-acf5-60e5a45491ee@linux.vnet.ibm.com \
--to=zyimin@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=haoqf@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).