From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Steve Sistare <steven.sistare@oracle.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Juan Quintela <quintela@redhat.com>,
David Hildenbrand <david@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH V3] memory: RAM_NAMED_FILE flag
Date: Tue, 13 Jun 2023 11:33:33 +0200 [thread overview]
Message-ID: <db75fc61-9686-5ae7-dff2-44e02a49ee66@linaro.org> (raw)
In-Reply-To: <1686151116-253260-1-git-send-email-steven.sistare@oracle.com>
On 7/6/23 17:18, Steve Sistare wrote:
> migrate_ignore_shared() is an optimization that avoids copying memory
> that is visible and can be mapped on the target. However, a
> memory-backend-ram or a memory-backend-memfd block with the RAM_SHARED
> flag set is not migrated when migrate_ignore_shared() is true. This is
> wrong, because the block has no named backing store, and its contents will
> be lost. To fix, ignore shared memory iff it is a named file. Define a
> new flag RAM_NAMED_FILE to distinguish this case.
>
> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> ---
> backends/hostmem-file.c | 1 +
> include/exec/cpu-common.h | 1 +
> include/exec/memory.h | 3 +++
> migration/ram.c | 3 ++-
> qapi/migration.json | 4 ++--
> softmmu/physmem.c | 7 ++++++-
> 6 files changed, 15 insertions(+), 4 deletions(-)
I'm taking this in my next PR, thanks.
prev parent reply other threads:[~2023-06-13 9:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 15:18 [PATCH V3] memory: RAM_NAMED_FILE flag Steve Sistare
2023-06-13 9:33 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db75fc61-9686-5ae7-dff2-44e02a49ee66@linaro.org \
--to=philmd@linaro.org \
--cc=david@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=steven.sistare@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).