From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>, Cornelia Huck <cohuck@redhat.com>,
"open list:S390 TCG CPUs" <qemu-s390x@nongnu.org>,
David Hildenbrand <david@redhat.com>
Subject: Re: [RFC PATCH] target/s390x: don't double ld_code() when reading instructions
Date: Tue, 12 Oct 2021 05:07:47 -0700 [thread overview]
Message-ID: <db799d87-836b-5f90-7f40-d946d8779c40@linaro.org> (raw)
In-Reply-To: <20211012093128.3909859-1-alex.bennee@linaro.org>
On 10/12/21 2:31 AM, Alex Bennée wrote:
> - case 6:
> - insn = (insn << 48) | (ld_code4(env, s, pc + 2) << 16);
> + case 6:
> + insn = deposit64(insn, 16, 32, ld_code4(env, s, pc + 2));
> break;
Looks like some of indentation error?
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-10-12 12:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 9:31 [RFC PATCH] target/s390x: don't double ld_code() when reading instructions Alex Bennée
2021-10-12 12:07 ` Richard Henderson [this message]
2021-10-12 12:10 ` Richard Henderson
2021-10-12 14:52 ` Alex Bennée
2021-10-12 15:38 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db799d87-836b-5f90-7f40-d946d8779c40@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).