From: Richard Henderson <richard.henderson@linaro.org>
To: Jiajie Chen <c@jia.je>, qemu-devel@nongnu.org
Cc: yijun@loongson.cn, shenjinyang@loongson.cn, gaosong@loongson.cn,
i.qemu@xen0n.name
Subject: Re: [PATCH v4 10/11] target/loongarch: Sign extend results in VA32 mode
Date: Tue, 8 Aug 2023 12:12:56 -0700 [thread overview]
Message-ID: <db9c1d60-937a-e17b-0449-b0e5be6d1152@linaro.org> (raw)
In-Reply-To: <20230808015506.1705140-11-c@jia.je>
On 8/7/23 18:54, Jiajie Chen wrote:
> --- a/target/loongarch/translate.c
> +++ b/target/loongarch/translate.c
> @@ -218,6 +218,19 @@ static TCGv va32_address(DisasContext *ctx, TCGv addr)
> return addr;
> }
>
> +static uint64_t sign_extend32(uint64_t data)
> +{
> + return (data & 0x7FFFFFFF) - (data & 0x80000000);
> +}
While correct, this is just (int32_t)data.
You can fold that into the only user.
> +
> +static uint64_t va32_result(DisasContext *ctx, uint64_t addr)
> +{
> + if (ctx->va32) {
> + addr = sign_extend32(addr);
> + }
> + return addr;
> +}
I would call this make_address_pc to match make_address_{i,x}.
r~
next prev parent reply other threads:[~2023-08-08 19:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 1:54 [PATCH v4 00/11] Add la32 & va32 mode for loongarch64-softmmu Jiajie Chen
2023-08-08 1:54 ` [PATCH v4 01/11] target/loongarch: Add macro to check current arch Jiajie Chen
2023-08-08 17:01 ` Richard Henderson
2023-08-08 17:13 ` Jiajie Chen
2023-08-10 11:08 ` Philippe Mathieu-Daudé
2023-08-10 11:06 ` Philippe Mathieu-Daudé
2023-08-08 1:54 ` [PATCH v4 02/11] target/loongarch: Add new object class for loongarch32 cpus Jiajie Chen
2023-08-08 18:19 ` Richard Henderson
2023-08-08 1:54 ` [PATCH v4 03/11] target/loongarch: Add GDB support for loongarch32 mode Jiajie Chen
2023-08-08 18:34 ` Richard Henderson
2023-08-08 1:54 ` [PATCH v4 04/11] target/loongarch: Support LoongArch32 TLB entry Jiajie Chen
2023-08-08 18:37 ` Richard Henderson
2023-08-08 1:54 ` [PATCH v4 05/11] target/loongarch: Support LoongArch32 DMW Jiajie Chen
2023-08-08 18:37 ` Richard Henderson
2023-08-08 1:54 ` [PATCH v4 06/11] target/loongarch: Support LoongArch32 VPPN Jiajie Chen
2023-08-08 18:38 ` Richard Henderson
2023-08-08 1:54 ` [PATCH v4 07/11] target/loongarch: Add LA32 & VA32 to DisasContext Jiajie Chen
2023-08-08 18:40 ` Richard Henderson
2023-08-08 1:54 ` [PATCH v4 08/11] target/loongarch: Reject la64-only instructions in la32 mode Jiajie Chen
2023-08-08 18:48 ` Richard Henderson
2023-08-08 1:54 ` [PATCH v4 09/11] target/loongarch: Truncate high 32 bits of address in VA32 mode Jiajie Chen
2023-08-08 19:08 ` Richard Henderson
2023-08-08 1:54 ` [PATCH v4 10/11] target/loongarch: Sign extend results " Jiajie Chen
2023-08-08 19:12 ` Richard Henderson [this message]
2023-08-08 1:54 ` [PATCH v4 11/11] target/loongarch: Add loongarch32 cpu la132 Jiajie Chen
2023-08-08 1:59 ` Jiajie Chen
2023-08-08 19:26 ` Richard Henderson
2023-08-09 7:31 ` Jiajie Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db9c1d60-937a-e17b-0449-b0e5be6d1152@linaro.org \
--to=richard.henderson@linaro.org \
--cc=c@jia.je \
--cc=gaosong@loongson.cn \
--cc=i.qemu@xen0n.name \
--cc=qemu-devel@nongnu.org \
--cc=shenjinyang@loongson.cn \
--cc=yijun@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).