From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A870DC433E0 for ; Tue, 30 Jun 2020 14:57:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75C402073E for ; Tue, 30 Jun 2020 14:57:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hjw7SSXF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75C402073E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jqHhC-00016y-Ic for qemu-devel@archiver.kernel.org; Tue, 30 Jun 2020 10:57:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jqHgH-0007nP-Fb for qemu-devel@nongnu.org; Tue, 30 Jun 2020 10:56:17 -0400 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:41208) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jqHgF-00037S-Mz for qemu-devel@nongnu.org; Tue, 30 Jun 2020 10:56:17 -0400 Received: by mail-pg1-x544.google.com with SMTP id g67so9169006pgc.8 for ; Tue, 30 Jun 2020 07:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ySo3IrSh2zZoDnqprPzVne9wIGX1iErVR4kH5ApU/H0=; b=hjw7SSXFPElCFqgqu2T2PdzyPXB8GDiCkSDgvXt3UTS3cN/m/GDDtPWdrkuvucsg4z 2xlqAB/3+K8FG0PBJCzVDFKSAGnNcHY0xNffXbbekxars7MYSSSEjCrVD37dOsttQ+P0 e7uITi66ZcBPyk160ae7HtFGp5H7BboWk9bnAuniDFpOtJTB7t5MnKsS1rn9ZivZxTTW Y0KjbpcMHz1E0pW3ooYRpE/I/HttUzrizmgsz38GHMRXxoBpSRuy9B30bHJ0Y5o0eanD K57cFKWnxJm+G7S3ChHgGElYpX4VseAJh5huwm0ouKRrHvln2WTytYRm1cqtSwAj8es+ jPDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ySo3IrSh2zZoDnqprPzVne9wIGX1iErVR4kH5ApU/H0=; b=bVR5u7dtUTlyOIaomKs2yULndnksQnUSUq+dGbx3QqsbvDBitoml77p1rarq6YqDbK tP36Y6cnB8JV/8eGLmX8HbKhcsC6HHe786M37j4gyCXeI3PDWaFvl8RqaWXo6owyoEU9 LqlgANoVT6c2WAVvG5HiSAzAjOysgc5giwdf65lFBJeUMHgpRWHqQSUv6eMuKdIk1FJY IEnwMSMksBjjUL0v0dt2wT7vsODj2Hn2l2gtWBnEjqt1ii80jwNSisc8fhUlYEqsC37d gYo+32vGBnK/68C3a9/7mqP6iAnCt5eOKpYIIUl2cjX/Fz/F3MCUJOrqcheIjMRf9szO l/pA== X-Gm-Message-State: AOAM5331KtmOlJvHWUcUUZVxJ7GBLlQc+B5Uua/mLZZlknYx2a5c5Q7r CN2JtioTPPyuaTKdftmSMW0uNA== X-Google-Smtp-Source: ABdhPJystL4w8DiZ8k+WJzM2zVVsTEGus27mUfQ3fODLg8E25R7NZGAhuVFnkmwRtqwuSzdNcE6Yyw== X-Received: by 2002:aa7:9630:: with SMTP id r16mr14000848pfg.144.1593528973633; Tue, 30 Jun 2020 07:56:13 -0700 (PDT) Received: from [192.168.1.11] (174-21-143-238.tukw.qwest.net. [174.21.143.238]) by smtp.gmail.com with ESMTPSA id cl17sm2584730pjb.50.2020.06.30.07.56.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2020 07:56:12 -0700 (PDT) Subject: Re: [PATCH 1/2] tcg/tcg-op: Fix nonatomic_op load with MO_SIGN To: LIU Zhiwei , qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <20200629130731.1080-1-zhiwei_liu@c-sky.com> <20200629130731.1080-2-zhiwei_liu@c-sky.com> From: Richard Henderson Message-ID: Date: Tue, 30 Jun 2020 07:56:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200629130731.1080-2-zhiwei_liu@c-sky.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::544; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x544.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: palmer@dabbelt.com, wenmeng_zhang@c-sky.com, Alistair.Francis@wdc.com, wxy194768@alibaba-inc.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/29/20 6:07 AM, LIU Zhiwei wrote: > @@ -3189,7 +3189,7 @@ static void do_nonatomic_op_i32(TCGv_i32 ret, TCGv addr, TCGv_i32 val, > > memop = tcg_canonicalize_memop(memop, 0, 0); > > - tcg_gen_qemu_ld_i32(t1, addr, idx, memop & ~MO_SIGN); > + tcg_gen_qemu_ld_i32(t1, addr, idx, memop); > gen(t2, t1, val); > tcg_gen_qemu_st_i32(t2, addr, idx, memop); > > @@ -3232,7 +3232,7 @@ static void do_nonatomic_op_i64(TCGv_i64 ret, TCGv addr, TCGv_i64 val, > > memop = tcg_canonicalize_memop(memop, 1, 0); > > - tcg_gen_qemu_ld_i64(t1, addr, idx, memop & ~MO_SIGN); > + tcg_gen_qemu_ld_i64(t1, addr, idx, memop); > gen(t2, t1, val); > tcg_gen_qemu_st_i64(t2, addr, idx, memop); This is insufficient for smin/smax -- we also need to extend the "val" input. r~