From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@redhat.com>,
mrezanin@redhat.com, Laurent Vivier <lvivier@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-4.0] tests/Makefile: Use some more CONFIG switches for x86 tests
Date: Thu, 29 Nov 2018 11:27:54 +0100 [thread overview]
Message-ID: <dba3373f-0709-2734-ae90-930573db83c9@redhat.com> (raw)
In-Reply-To: <1543487139-28462-1-git-send-email-thuth@redhat.com>
On 29/11/18 11:25, Thomas Huth wrote:
> To be able to build and test QEMU binaries where certain devices are
> disabled, we have to use the right CONFIG_* switches to run certain
> tests only if the corresponding device really has been compiled into
> the binary.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
No objection, but CONFIG_VIRTIO and CONFIG_MEGASAS_SCSI_PCI would not be
needed with qgraph (which I'm going to post Real Soon Now).
Paolo
> ---
> tests/Makefile.include | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index fb0b449..d87b403 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -165,13 +165,13 @@ check-qtest-pci-$(CONFIG_NE2000_PCI) += tests/ne2000-test$(EXESUF)
> check-qtest-pci-$(CONFIG_NVME_PCI) += tests/nvme-test$(EXESUF)
> check-qtest-pci-$(CONFIG_AC97) += tests/ac97-test$(EXESUF)
> check-qtest-pci-$(CONFIG_ES1370) += tests/es1370-test$(EXESUF)
> -check-qtest-pci-y += $(check-qtest-virtio-y)
> +check-qtest-pci-$(CONFIG_VIRTIO) += $(check-qtest-virtio-y)
> check-qtest-pci-$(CONFIG_IPACK) += tests/tpci200-test$(EXESUF)
> check-qtest-pci-$(CONFIG_IPACK) += $(check-qtest-ipack-y)
> -check-qtest-pci-y += tests/display-vga-test$(EXESUF)
> +check-qtest-pci-$(CONFIG_VGA) += tests/display-vga-test$(EXESUF)
> check-qtest-pci-$(CONFIG_HDA) += tests/intel-hda-test$(EXESUF)
> check-qtest-pci-$(CONFIG_IVSHMEM_DEVICE) += tests/ivshmem-test$(EXESUF)
> -check-qtest-pci-y += tests/megasas-test$(EXESUF)
> +check-qtest-pci-$(CONFIG_MEGASAS_SCSI_PCI) += tests/megasas-test$(EXESUF)
>
> check-qtest-i386-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF)
> check-qtest-i386-y += tests/fdc-test$(EXESUF)
> @@ -183,8 +183,8 @@ check-qtest-i386-y += tests/bios-tables-test$(EXESUF)
> check-qtest-i386-$(CONFIG_SGA) += tests/boot-serial-test$(EXESUF)
> check-qtest-i386-$(CONFIG_SLIRP) += tests/pxe-test$(EXESUF)
> check-qtest-i386-y += tests/rtc-test$(EXESUF)
> -check-qtest-i386-y += tests/ipmi-kcs-test$(EXESUF)
> -check-qtest-i386-y += tests/ipmi-bt-test$(EXESUF)
> +check-qtest-i386-$(CONFIG_ISA_IPMI_KCS) += tests/ipmi-kcs-test$(EXESUF)
> +check-qtest-i386-$(CONFIG_ISA_IPMI_BT) += tests/ipmi-bt-test$(EXESUF)
> check-qtest-i386-y += tests/i440fx-test$(EXESUF)
> check-qtest-i386-y += tests/fw_cfg-test$(EXESUF)
> check-qtest-i386-y += tests/drive_del-test$(EXESUF)
>
prev parent reply other threads:[~2018-11-29 10:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 10:25 [Qemu-devel] [PATCH for-4.0] tests/Makefile: Use some more CONFIG switches for x86 tests Thomas Huth
2018-11-29 10:27 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dba3373f-0709-2734-ae90-930573db83c9@redhat.com \
--to=pbonzini@redhat.com \
--cc=lvivier@redhat.com \
--cc=mrezanin@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).