From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSJY8-0007uS-B2 for qemu-devel@nongnu.org; Thu, 29 Nov 2018 05:28:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSJY7-00058p-Ho for qemu-devel@nongnu.org; Thu, 29 Nov 2018 05:28:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58514) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gSJY7-00058Q-7d for qemu-devel@nongnu.org; Thu, 29 Nov 2018 05:27:59 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 85AB73C2CD9 for ; Thu, 29 Nov 2018 10:27:58 +0000 (UTC) References: <1543487139-28462-1-git-send-email-thuth@redhat.com> From: Paolo Bonzini Message-ID: Date: Thu, 29 Nov 2018 11:27:54 +0100 MIME-Version: 1.0 In-Reply-To: <1543487139-28462-1-git-send-email-thuth@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-4.0] tests/Makefile: Use some more CONFIG switches for x86 tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org Cc: Juan Quintela , mrezanin@redhat.com, Laurent Vivier On 29/11/18 11:25, Thomas Huth wrote: > To be able to build and test QEMU binaries where certain devices are > disabled, we have to use the right CONFIG_* switches to run certain > tests only if the corresponding device really has been compiled into > the binary. > > Signed-off-by: Thomas Huth No objection, but CONFIG_VIRTIO and CONFIG_MEGASAS_SCSI_PCI would not be needed with qgraph (which I'm going to post Real Soon Now). Paolo > --- > tests/Makefile.include | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index fb0b449..d87b403 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -165,13 +165,13 @@ check-qtest-pci-$(CONFIG_NE2000_PCI) += tests/ne2000-test$(EXESUF) > check-qtest-pci-$(CONFIG_NVME_PCI) += tests/nvme-test$(EXESUF) > check-qtest-pci-$(CONFIG_AC97) += tests/ac97-test$(EXESUF) > check-qtest-pci-$(CONFIG_ES1370) += tests/es1370-test$(EXESUF) > -check-qtest-pci-y += $(check-qtest-virtio-y) > +check-qtest-pci-$(CONFIG_VIRTIO) += $(check-qtest-virtio-y) > check-qtest-pci-$(CONFIG_IPACK) += tests/tpci200-test$(EXESUF) > check-qtest-pci-$(CONFIG_IPACK) += $(check-qtest-ipack-y) > -check-qtest-pci-y += tests/display-vga-test$(EXESUF) > +check-qtest-pci-$(CONFIG_VGA) += tests/display-vga-test$(EXESUF) > check-qtest-pci-$(CONFIG_HDA) += tests/intel-hda-test$(EXESUF) > check-qtest-pci-$(CONFIG_IVSHMEM_DEVICE) += tests/ivshmem-test$(EXESUF) > -check-qtest-pci-y += tests/megasas-test$(EXESUF) > +check-qtest-pci-$(CONFIG_MEGASAS_SCSI_PCI) += tests/megasas-test$(EXESUF) > > check-qtest-i386-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) > check-qtest-i386-y += tests/fdc-test$(EXESUF) > @@ -183,8 +183,8 @@ check-qtest-i386-y += tests/bios-tables-test$(EXESUF) > check-qtest-i386-$(CONFIG_SGA) += tests/boot-serial-test$(EXESUF) > check-qtest-i386-$(CONFIG_SLIRP) += tests/pxe-test$(EXESUF) > check-qtest-i386-y += tests/rtc-test$(EXESUF) > -check-qtest-i386-y += tests/ipmi-kcs-test$(EXESUF) > -check-qtest-i386-y += tests/ipmi-bt-test$(EXESUF) > +check-qtest-i386-$(CONFIG_ISA_IPMI_KCS) += tests/ipmi-kcs-test$(EXESUF) > +check-qtest-i386-$(CONFIG_ISA_IPMI_BT) += tests/ipmi-bt-test$(EXESUF) > check-qtest-i386-y += tests/i440fx-test$(EXESUF) > check-qtest-i386-y += tests/fw_cfg-test$(EXESUF) > check-qtest-i386-y += tests/drive_del-test$(EXESUF) >