From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Gavin Shan <gshan@redhat.com>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, "Joel Stanley" <joel@jms.id.au>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Cédric Le Goater" <clg@kaod.org>
Subject: Re: [PATCH v2 3/5] hw/arm/aspeed: Init CPU defaults in a common helper
Date: Thu, 25 Jan 2024 05:50:39 +0100 [thread overview]
Message-ID: <dbb0a39c-7495-4c38-9915-bb69fe86728f@linaro.org> (raw)
In-Reply-To: <3aeb1471-dc88-4971-9e77-e1896e40d446@redhat.com>
On 25/1/24 03:26, Gavin Shan wrote:
> Hi Phil,
>
> On 1/24/24 08:48, Philippe Mathieu-Daudé wrote:
>> Rework aspeed_soc_num_cpus() as a new init_cpus_defaults()
>> helper to reduce code duplication.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>> hw/arm/aspeed.c | 71 +++++++++++++++++++------------------------------
>> 1 file changed, 28 insertions(+), 43 deletions(-)
>>
>
> One nit needs to be addressed:
>
> Reviewed-by: Gavin Shan <gshan@redhat.com>
> Failure from './scripts/checkpatch.pl --strict'
>
> ERROR: do not use C99 // comments
> #216: FILE: hw/arm/aspeed.c:1505:
> + aspeed_machine_class_init_cpus_defaults(mc); //
Oops, forgot to clean that =) Thanks!
next prev parent reply other threads:[~2024-01-25 4:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 22:48 [PATCH v2 0/5] hw/arm/aspeed: Check for CPU types in machine_run_board_init() Philippe Mathieu-Daudé
2024-01-23 22:48 ` [PATCH v2 1/5] hw/arm/aspeed: Remove dead code Philippe Mathieu-Daudé
2024-01-24 6:50 ` Cédric Le Goater
2024-01-24 23:12 ` Richard Henderson
2024-01-25 2:21 ` Gavin Shan
2024-01-23 22:48 ` [PATCH v2 2/5] hw/arm/aspeed: Set default CPU count using aspeed_soc_num_cpus() Philippe Mathieu-Daudé
2024-01-24 6:52 ` Cédric Le Goater
2024-01-25 2:23 ` Gavin Shan
2024-01-23 22:48 ` [PATCH v2 3/5] hw/arm/aspeed: Init CPU defaults in a common helper Philippe Mathieu-Daudé
2024-01-24 6:58 ` Cédric Le Goater
2024-01-24 23:15 ` Richard Henderson
2024-01-25 2:26 ` Gavin Shan
2024-01-25 4:50 ` Philippe Mathieu-Daudé [this message]
2024-01-23 22:48 ` [PATCH v2 4/5] hw/arm/aspeed: Introduce aspeed_soc_cpu_type() helper Philippe Mathieu-Daudé
2024-01-24 6:58 ` Cédric Le Goater
2024-01-24 23:17 ` Richard Henderson
2024-01-25 2:27 ` Gavin Shan
2024-01-23 22:48 ` [PATCH v2 5/5] hw/arm/aspeed: Check for CPU types in machine_run_board_init() Philippe Mathieu-Daudé
2024-01-24 6:59 ` Cédric Le Goater
2024-01-24 23:18 ` Richard Henderson
2024-01-25 2:28 ` Gavin Shan
2024-01-23 22:50 ` [PATCH v2 0/5] " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbb0a39c-7495-4c38-9915-bb69fe86728f@linaro.org \
--to=philmd@linaro.org \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=gshan@redhat.com \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).