From: Eric Farman <farman@linux.ibm.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Eduardo Habkost <eduardo@habkost.net>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
qemu-s390x@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Ani Sinha <anisinha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Yanan Wang <wangyanan55@huawei.com>,
David Hildenbrand <david@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Markus Armbruster <armbru@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Thomas Huth <thuth@redhat.com>, Halil Pasic <pasic@linux.ibm.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Ilya Leoshkevich <iii@linux.ibm.com>
Subject: Re: [PATCH 6/6] hw/s390x: Clean up global variable shadowing in quiesce_powerdown_req()
Date: Wed, 11 Oct 2023 07:58:51 -0400 [thread overview]
Message-ID: <dbb857cfde3c03aae4233ad8d8d560124e947959.camel@linux.ibm.com> (raw)
In-Reply-To: <20231009094747.54240-7-philmd@linaro.org>
On Mon, 2023-10-09 at 11:47 +0200, Philippe Mathieu-Daudé wrote:
> Fix:
>
> hw/s390x/sclpquiesce.c:90:22: error: declaration shadows a variable
> in the global scope [-Werror,-Wshadow]
> QuiesceNotifier *qn = container_of(n, QuiesceNotifier,
> notifier);
> ^
> hw/s390x/sclpquiesce.c:86:3: note: previous declaration is here
> } qn;
> ^
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/s390x/sclpquiesce.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Eric Farman <farman@linux.ibm.com>
prev parent reply other threads:[~2023-10-11 12:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 9:47 [PATCH 0/6] hw: Clean up global variables shadowing Philippe Mathieu-Daudé
2023-10-09 9:47 ` [PATCH 1/6] hw/core/cpu: Clean up global variable shadowing Philippe Mathieu-Daudé
2023-10-09 9:47 ` [PATCH 2/6] hw/loader: Clean up global variable shadowing in rom_add_file() Philippe Mathieu-Daudé
2023-10-09 12:25 ` Ani Sinha
2023-10-09 9:47 ` [PATCH 3/6] hw/display/vga: Clean up global variable shadowing Philippe Mathieu-Daudé
2023-10-09 14:11 ` Ani Sinha
2023-10-09 15:43 ` Philippe Mathieu-Daudé
2023-10-09 9:47 ` [PATCH 4/6] hw/acpi/pcihp: Clean up global variable shadowing in acpi_pcihp_init() Philippe Mathieu-Daudé
2023-10-09 12:04 ` Ani Sinha
2023-10-09 16:22 ` Michael S. Tsirkin
2023-10-09 9:47 ` [PATCH 5/6] hw/pci: Clean up global variable shadowing of address_space_io variable Philippe Mathieu-Daudé
2023-10-09 16:22 ` Michael S. Tsirkin
2023-10-09 9:47 ` [PATCH 6/6] hw/s390x: Clean up global variable shadowing in quiesce_powerdown_req() Philippe Mathieu-Daudé
2023-10-09 9:51 ` Thomas Huth
2023-10-09 9:52 ` David Hildenbrand
2023-10-11 11:58 ` Eric Farman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbb857cfde3c03aae4233ad8d8d560124e947959.camel@linux.ibm.com \
--to=farman@linux.ibm.com \
--cc=anisinha@redhat.com \
--cc=armbru@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=eduardo@habkost.net \
--cc=iii@linux.ibm.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).