From: Richard Henderson <richard.henderson@linaro.org>
To: Victor Colombo <victor.colombo@eldorado.org.br>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: danielhb413@gmail.com, matheus.ferst@eldorado.org.br,
groug@kaod.org, david@gibson.dropbear.id.au, clg@kaod.org
Subject: Re: [PATCH 1/4] target/ppc: Fix xs{max,min}[cj]dp to use VSX registers
Date: Sat, 11 Dec 2021 09:02:12 -0800 [thread overview]
Message-ID: <dbbb0877-7039-19d4-a03d-af78539174f4@linaro.org> (raw)
In-Reply-To: <20211210141347.38603-2-victor.colombo@eldorado.org.br>
On 12/10/21 6:13 AM, Victor Colombo wrote:
> PPC instruction xsmaxcdp, xsmincdp, xsmaxjdp, and xsminjdp are using
> vector registers when they should be using VSX ones. This happens
> because the instructions are using GEN_VSX_HELPER_R3, which adds 32
> to the register numbers, effectively making them vector registers.
>
> This patch fixes it by changing these instructions to use
> GEN_VSX_HELPER_X3.
>
> Signed-off-by: Victor Colombo<victor.colombo@eldorado.org.br>
> ---
> target/ppc/fpu_helper.c | 4 ++--
> target/ppc/helper.h | 8 ++++----
> target/ppc/translate/vsx-impl.c.inc | 8 ++++----
> 3 files changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-12-11 17:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 14:13 [PATCH 0/4] target/ppc: Fix VSX instructions register access Victor Colombo
2021-12-10 14:13 ` [PATCH 1/4] target/ppc: Fix xs{max,min}[cj]dp to use VSX registers Victor Colombo
2021-12-11 17:02 ` Richard Henderson [this message]
2021-12-10 14:13 ` [PATCH 2/4] target/ppc: Move xs{max,min}[cj]dp to decodetree Victor Colombo
2021-12-11 17:03 ` Richard Henderson
2021-12-10 14:13 ` [PATCH 3/4] target/ppc: fix xscvqpdp register access Victor Colombo
2021-12-11 17:05 ` Richard Henderson
2021-12-10 14:13 ` [PATCH 4/4] target/ppc: move xscvqpdp to decodetree Victor Colombo
2021-12-10 16:19 ` Matheus K. Ferst
2021-12-11 17:07 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbbb0877-7039-19d4-a03d-af78539174f4@linaro.org \
--to=richard.henderson@linaro.org \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=victor.colombo@eldorado.org.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).