From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNiIh-0002Px-ER for qemu-devel@nongnu.org; Thu, 14 Jul 2016 11:11:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNiIb-0006uj-Ch for qemu-devel@nongnu.org; Thu, 14 Jul 2016 11:11:42 -0400 References: <1468484058-8719-1-git-send-email-thuth@redhat.com> <5787A27B.8020703@redhat.com> From: Thomas Huth Message-ID: Date: Thu, 14 Jul 2016 17:11:26 +0200 MIME-Version: 1.0 In-Reply-To: <5787A27B.8020703@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4EtEv2tQjlDXGxjxv4mkgjFB2UvdrmBUo" Subject: Re: [Qemu-devel] [PATCH] ppc/mmu-hash64: Remove duplicated #include statement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-ppc@nongnu.org, david@gibson.dropbear.id.au Cc: qemu-devel@nongnu.org, Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4EtEv2tQjlDXGxjxv4mkgjFB2UvdrmBUo Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 14.07.2016 16:32, Eric Blake wrote: > On 07/14/2016 02:14 AM, Thomas Huth wrote: >> No need to include error-report.h twice here. >> >> Signed-off-by: Thomas Huth >> --- >> target-ppc/mmu-hash64.c | 1 - >> 1 file changed, 1 deletion(-) >=20 > Reviewed-by: Eric Blake >=20 > Markus, do your header cleanup scripts detect any other situations like= > this? There are indeed other files that include headers twice. You can get an inaccurate list with following shell magic: for i in `find include/ -name \*.h` ; do \ grep -r '#include.*'`echo -n $i | sed s,include/,,` * \ | sed s/:.*$// | sort > /tmp/dups1.txt ; \ sort -u /tmp/dups2.txt; \ DIF=3D`diff /tmp/dups?.txt | grep '\.[ch]' | tr \< \-` ; \ if [ "x$DIF" !=3D x ] ; then \ echo '***' $i '***': ; echo $DIF ; echo; \ fi ; \ done Note that there are also valid cases where a file is including a header multiple times (e.g. the way include/exec/cpu_ldst.h is including cpu_ldst_template.h multiple times), so there are also false-positives in this list. But for the others ... feel free to send some patches ;-) Thomas --4EtEv2tQjlDXGxjxv4mkgjFB2UvdrmBUo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJXh6ulAAoJEC7Z13T+cC21FdwP/RsQhBkWPPj7KzuKiNRIXPQx khPD89+3aVEw4GuVZXA+7DNdBy/Uxrn7NfMsMksjJn/2U022cL+1rPt7K26t7bNy dtARC5fX6yCSPLdNgsOOX21OzxDzRr8ZkFGrKJqXp+sNfY44BzoMoBqf6F5lUadv EutRdon8KXcAOOvHSO3h1Qz3pfNCrckaCpeMR8EbjWDTNpvpH+1PR96du3zbUvDd 27c2bMMrsM++HPuwiEGUNm+kaxZXsmsQClTQywxAN5H8u36D8QB7k+OK9+wwB6Pv mvExWzxFB9wUPPLOQZ0B86HjUKBzNUP717S+7H5Ny+Wpn1r8Awq+vNYxemLR8hXx CPGBpz9VO1Yh2fu2owgl/KFOtg/GV6riXptSA9LkZJsqRRU6U0BQ0cmNnqU0+hIE Sjmp0OLmNXwsmdnKo7OVJ4V8Ekcxn6uK5iSbDZzNadUskLMVZhphtB6HCkZiyfTO tFwlHdzZv6udj0qoVZo+IC6L6dV/u9ib8Evfrp5tpqMxLMorwSTFxlp5z8lAULKy rbutJLl5hGEIoHk5AIsmyivrj8yR9o4I/T8923lIPQ4iCOlqixkCRN/Ud083/ey4 oPMTYeb5IMaG/xFB/wLws1OxYIkBJNUcHCh/6dmz6nzQL+d8OXbg4ymrkgwl5S0p s7sjgh1J6QFkPASM+Axn =VK3m -----END PGP SIGNATURE----- --4EtEv2tQjlDXGxjxv4mkgjFB2UvdrmBUo--