* Re: [PATCH] pc-bios/descriptors: fix paths in json files [not found] <20210131143434.2513363-1-slyfox@gentoo.org> @ 2021-01-31 14:56 ` Philippe Mathieu-Daudé 2021-01-31 15:22 ` Jannik Glückert 2021-02-01 8:31 ` Paolo Bonzini 1 sibling, 1 reply; 4+ messages in thread From: Philippe Mathieu-Daudé @ 2021-01-31 14:56 UTC (permalink / raw) To: Jannik Glückert Cc: Paolo Bonzini, qemu-devel, Sergei Trofimovich, Marc-André Lureau On 1/31/21 3:34 PM, Sergei Trofimovich wrote: > Before the change /usr/share/qemu/firmware/50-edk2-x86_64-secure.json > contained the relative path: > "filename": "share/qemu/edk2-x86_64-secure-code.fd", > "filename": "share/qemu/edk2-i386-vars.fd", > > After then change the paths are absolute: > "filename": "/usr/share/qemu/edk2-x86_64-secure-code.fd", > "filename": "/usr/share/qemu/edk2-i386-vars.fd", > > The regression appeared in qemu-5.2.0 (seems to be related > to meson port). > > CC: Paolo Bonzini <pbonzini@redhat.com> > CC: "Marc-André Lureau" <marcandre.lureau@redhat.com> > CC: "Philippe Mathieu-Daudé" <philmd@redhat.com> > Bug: https://bugs.gentoo.org/766743 > Bug: https://bugs.launchpad.net/qemu/+bug/1913012 > Patch-by: Jannik Glückert Thanks Jannik and Sergei to fix this issue, I noticed the LP#1913012 and planned to look at it tomorrow :) Jannik, can you send a Signed-off-by line so we can accept your patch? See: https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line Otherwise: Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> > --- > pc-bios/descriptors/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pc-bios/descriptors/meson.build b/pc-bios/descriptors/meson.build > index ac6ec66b00..29efa16d99 100644 > --- a/pc-bios/descriptors/meson.build > +++ b/pc-bios/descriptors/meson.build > @@ -9,7 +9,7 @@ if install_edk2_blobs > ] > configure_file(input: files(f), > output: f, > - configuration: {'DATADIR': qemu_datadir}, > + configuration: {'DATADIR': get_option('prefix') / qemu_datadir}, > install: get_option('install_blobs'), > install_dir: qemu_datadir / 'firmware') > endforeach > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pc-bios/descriptors: fix paths in json files 2021-01-31 14:56 ` [PATCH] pc-bios/descriptors: fix paths in json files Philippe Mathieu-Daudé @ 2021-01-31 15:22 ` Jannik Glückert 2021-01-31 16:21 ` Philippe Mathieu-Daudé 0 siblings, 1 reply; 4+ messages in thread From: Jannik Glückert @ 2021-01-31 15:22 UTC (permalink / raw) To: Philippe Mathieu-Daudé Cc: Paolo Bonzini, qemu-devel, Sergei Trofimovich, Marc-André Lureau > Jannik, can you send a Signed-off-by line so we can accept > your patch? See: > https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line Sure! I hope this is right, I'm not exactly experienced with mailing list development. Signed-off-by: Jannik Glückert <jannik.glueckert@gmail.com> > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > > Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> > > --- > > pc-bios/descriptors/meson.build | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/pc-bios/descriptors/meson.build b/pc-bios/descriptors/meson.build > > index ac6ec66b00..29efa16d99 100644 > > --- a/pc-bios/descriptors/meson.build > > +++ b/pc-bios/descriptors/meson.build > > @@ -9,7 +9,7 @@ if install_edk2_blobs > > ] > > configure_file(input: files(f), > > output: f, > > - configuration: {'DATADIR': qemu_datadir}, > > + configuration: {'DATADIR': get_option('prefix') / qemu_datadir}, > > install: get_option('install_blobs'), > > install_dir: qemu_datadir / 'firmware') > > endforeach > > Am So., 31. Jan. 2021 um 15:56 Uhr schrieb Philippe Mathieu-Daudé <philmd@redhat.com>: > > On 1/31/21 3:34 PM, Sergei Trofimovich wrote: > > Before the change /usr/share/qemu/firmware/50-edk2-x86_64-secure.json > > contained the relative path: > > "filename": "share/qemu/edk2-x86_64-secure-code.fd", > > "filename": "share/qemu/edk2-i386-vars.fd", > > > > After then change the paths are absolute: > > "filename": "/usr/share/qemu/edk2-x86_64-secure-code.fd", > > "filename": "/usr/share/qemu/edk2-i386-vars.fd", > > > > The regression appeared in qemu-5.2.0 (seems to be related > > to meson port). > > > > CC: Paolo Bonzini <pbonzini@redhat.com> > > CC: "Marc-André Lureau" <marcandre.lureau@redhat.com> > > CC: "Philippe Mathieu-Daudé" <philmd@redhat.com> > > Bug: https://bugs.gentoo.org/766743 > > Bug: https://bugs.launchpad.net/qemu/+bug/1913012 > > Patch-by: Jannik Glückert > > Thanks Jannik and Sergei to fix this issue, I noticed > the LP#1913012 and planned to look at it tomorrow :) > > Jannik, can you send a Signed-off-by line so we can accept > your patch? See: > https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line > > Otherwise: > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > > Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> > > --- > > pc-bios/descriptors/meson.build | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/pc-bios/descriptors/meson.build b/pc-bios/descriptors/meson.build > > index ac6ec66b00..29efa16d99 100644 > > --- a/pc-bios/descriptors/meson.build > > +++ b/pc-bios/descriptors/meson.build > > @@ -9,7 +9,7 @@ if install_edk2_blobs > > ] > > configure_file(input: files(f), > > output: f, > > - configuration: {'DATADIR': qemu_datadir}, > > + configuration: {'DATADIR': get_option('prefix') / qemu_datadir}, > > install: get_option('install_blobs'), > > install_dir: qemu_datadir / 'firmware') > > endforeach > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pc-bios/descriptors: fix paths in json files 2021-01-31 15:22 ` Jannik Glückert @ 2021-01-31 16:21 ` Philippe Mathieu-Daudé 0 siblings, 0 replies; 4+ messages in thread From: Philippe Mathieu-Daudé @ 2021-01-31 16:21 UTC (permalink / raw) To: Jannik Glückert, QEMU Trivial, qemu-stable@nongnu.org Cc: Paolo Bonzini, qemu-devel, Sergei Trofimovich, Marc-André Lureau On 1/31/21 4:22 PM, Jannik Glückert wrote: >> Jannik, can you send a Signed-off-by line so we can accept >> your patch? See: >> https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line > > Sure! I hope this is right, I'm not exactly experienced with mailing > list development. > > Signed-off-by: Jannik Glückert <jannik.glueckert@gmail.com> Yes, perfect :) >> >> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> >> >>> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> >>> --- >>> pc-bios/descriptors/meson.build | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/pc-bios/descriptors/meson.build b/pc-bios/descriptors/meson.build >>> index ac6ec66b00..29efa16d99 100644 >>> --- a/pc-bios/descriptors/meson.build >>> +++ b/pc-bios/descriptors/meson.build >>> @@ -9,7 +9,7 @@ if install_edk2_blobs >>> ] >>> configure_file(input: files(f), >>> output: f, >>> - configuration: {'DATADIR': qemu_datadir}, >>> + configuration: {'DATADIR': get_option('prefix') / qemu_datadir}, >>> install: get_option('install_blobs'), >>> install_dir: qemu_datadir / 'firmware') >>> endforeach >>> > > > Am So., 31. Jan. 2021 um 15:56 Uhr schrieb Philippe Mathieu-Daudé > <philmd@redhat.com>: >> >> On 1/31/21 3:34 PM, Sergei Trofimovich wrote: >>> Before the change /usr/share/qemu/firmware/50-edk2-x86_64-secure.json >>> contained the relative path: >>> "filename": "share/qemu/edk2-x86_64-secure-code.fd", >>> "filename": "share/qemu/edk2-i386-vars.fd", >>> >>> After then change the paths are absolute: >>> "filename": "/usr/share/qemu/edk2-x86_64-secure-code.fd", >>> "filename": "/usr/share/qemu/edk2-i386-vars.fd", >>> >>> The regression appeared in qemu-5.2.0 (seems to be related >>> to meson port). Cc: qemu-stable@nongnu.org Cc'ing qemu-trivial@ now (I can respin with all tags sorted if it is easier). >>> CC: Paolo Bonzini <pbonzini@redhat.com> >>> CC: "Marc-André Lureau" <marcandre.lureau@redhat.com> >>> CC: "Philippe Mathieu-Daudé" <philmd@redhat.com> >>> Bug: https://bugs.gentoo.org/766743 >>> Bug: https://bugs.launchpad.net/qemu/+bug/1913012 >>> Patch-by: Jannik Glückert >> >> Thanks Jannik and Sergei to fix this issue, I noticed >> the LP#1913012 and planned to look at it tomorrow :) >> >> Jannik, can you send a Signed-off-by line so we can accept >> your patch? See: >> https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line >> >> Otherwise: >> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> >> >>> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> >>> --- >>> pc-bios/descriptors/meson.build | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/pc-bios/descriptors/meson.build b/pc-bios/descriptors/meson.build >>> index ac6ec66b00..29efa16d99 100644 >>> --- a/pc-bios/descriptors/meson.build >>> +++ b/pc-bios/descriptors/meson.build >>> @@ -9,7 +9,7 @@ if install_edk2_blobs >>> ] >>> configure_file(input: files(f), >>> output: f, >>> - configuration: {'DATADIR': qemu_datadir}, >>> + configuration: {'DATADIR': get_option('prefix') / qemu_datadir}, >>> install: get_option('install_blobs'), >>> install_dir: qemu_datadir / 'firmware') >>> endforeach >>> >> > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pc-bios/descriptors: fix paths in json files [not found] <20210131143434.2513363-1-slyfox@gentoo.org> 2021-01-31 14:56 ` [PATCH] pc-bios/descriptors: fix paths in json files Philippe Mathieu-Daudé @ 2021-02-01 8:31 ` Paolo Bonzini 1 sibling, 0 replies; 4+ messages in thread From: Paolo Bonzini @ 2021-02-01 8:31 UTC (permalink / raw) To: Sergei Trofimovich, qemu-devel Cc: Marc-André Lureau, Philippe Mathieu-Daudé On 31/01/21 15:34, Sergei Trofimovich wrote: > Before the change /usr/share/qemu/firmware/50-edk2-x86_64-secure.json > contained the relative path: > "filename": "share/qemu/edk2-x86_64-secure-code.fd", > "filename": "share/qemu/edk2-i386-vars.fd", > > After then change the paths are absolute: > "filename": "/usr/share/qemu/edk2-x86_64-secure-code.fd", > "filename": "/usr/share/qemu/edk2-i386-vars.fd", > > The regression appeared in qemu-5.2.0 (seems to be related > to meson port). > > CC: Paolo Bonzini <pbonzini@redhat.com> > CC: "Marc-André Lureau" <marcandre.lureau@redhat.com> > CC: "Philippe Mathieu-Daudé" <philmd@redhat.com> > Bug: https://bugs.gentoo.org/766743 > Bug: https://bugs.launchpad.net/qemu/+bug/1913012 > Patch-by: Jannik Glückert > Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> > --- > pc-bios/descriptors/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pc-bios/descriptors/meson.build b/pc-bios/descriptors/meson.build > index ac6ec66b00..29efa16d99 100644 > --- a/pc-bios/descriptors/meson.build > +++ b/pc-bios/descriptors/meson.build > @@ -9,7 +9,7 @@ if install_edk2_blobs > ] > configure_file(input: files(f), > output: f, > - configuration: {'DATADIR': qemu_datadir}, > + configuration: {'DATADIR': get_option('prefix') / qemu_datadir}, > install: get_option('install_blobs'), > install_dir: qemu_datadir / 'firmware') > endforeach > Queued, thanks! Paolo ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-01 8:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210131143434.2513363-1-slyfox@gentoo.org>
2021-01-31 14:56 ` [PATCH] pc-bios/descriptors: fix paths in json files Philippe Mathieu-Daudé
2021-01-31 15:22 ` Jannik Glückert
2021-01-31 16:21 ` Philippe Mathieu-Daudé
2021-02-01 8:31 ` Paolo Bonzini
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).