Re: [PATCH-for-8.0 2/5] cpu: Move cpu_class_init_props() to common code

[Richard Henderson <richard.henderson@linaro.org>]

On 11/30/22 05:52, Philippe Mathieu-Daudé wrote:
> This code is not target-specific.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   cpu.c         | 53 ---------------------------------------------------
>   cpus-common.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 53 insertions(+), 53 deletions(-)
> 
> diff --git a/cpu.c b/cpu.c
> index 4a7d865427..d4b24ea39a 100644
> --- a/cpu.c
> +++ b/cpu.c
> @@ -21,8 +21,6 @@
>   #include "qapi/error.h"
>   
>   #include "exec/target_page.h"
> -#include "hw/qdev-core.h"
> -#include "hw/qdev-properties.h"
>   #include "qemu/error-report.h"
>   #include "migration/vmstate.h"
>   #ifdef CONFIG_USER_ONLY
> @@ -183,57 +181,6 @@ void cpu_exec_unrealizefn(CPUState *cpu)
>       cpu_list_remove(cpu);
>   }
>   
> -/*
> - * This can't go in hw/core/cpu.c because that file is compiled only
> - * once for both user-mode and system builds.
> - */
> -static Property cpu_common_props[] = {
> -#ifdef CONFIG_USER_ONLY

It is "target" specific in the general sense, in that CONFIG_USER_ONLY is either set or unset.


r~