qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>, qemu-devel@nongnu.org
Cc: crosa@redhat.com, philmd@redhat.com, ehabkost@redhat.com,
	lizhijian@cn.fujitsu.com, ccarrara@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] Acceptance tests: add Linux initrd checking test
Date: Tue, 13 Nov 2018 10:08:40 -0600	[thread overview]
Message-ID: <dbde7c87-b0b2-becc-0176-609befb40e1a@redhat.com> (raw)
In-Reply-To: <20181109182153.5390-1-wainersm@redhat.com>

On 11/9/18 12:21 PM, Wainer dos Santos Moschetta wrote:
> QEMU used to exits with a not accurate error message when

s/exits/exit/
s/a not accurate/an inaccurate/

> an initrd > 2GiB was passed. That was fixed on patch:
> 
> 	commit f3839fda5771596152b75dd1e1a6d050e6e6e380
> 	Author: Li Zhijian <lizhijian@cn.fujitsu.com>
> 	Date:   Thu Sep 13 18:07:13 2018 +0800
> 
>      	change get_image_size return type to int64_t
> 
> This change adds a regression test for that fix. It starts
> QEMU with a 2GiB dummy initrd, and check it evaluates the file

s/check/checks that/

> size correctly and prints accurate message.

s/accurate/an accurate/

> 
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> Reviewed-by: Caio Carrara <ccarrara@redhat.com>
> Reviewed-by: Cleber Rosa <crosa@redhat.com>
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

  parent reply	other threads:[~2018-11-13 16:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09 18:21 [Qemu-devel] [PATCH v2] Acceptance tests: add Linux initrd checking test Wainer dos Santos Moschetta
2018-11-13  2:11 ` Eduardo Habkost
2018-11-13 16:08 ` Eric Blake [this message]
2018-11-15 14:41   ` Wainer dos Santos Moschetta
2018-11-19 23:16     ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbde7c87-b0b2-becc-0176-609befb40e1a@redhat.com \
    --to=eblake@redhat.com \
    --cc=ccarrara@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).