From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC72C4361B for ; Wed, 16 Dec 2020 15:28:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D22823371 for ; Wed, 16 Dec 2020 15:28:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D22823371 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53116 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpYjU-00080T-6i for qemu-devel@archiver.kernel.org; Wed, 16 Dec 2020 10:28:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpYez-0004pz-JR for qemu-devel@nongnu.org; Wed, 16 Dec 2020 10:24:13 -0500 Received: from mail-oo1-xc31.google.com ([2607:f8b0:4864:20::c31]:45315) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpYex-0006No-Jd for qemu-devel@nongnu.org; Wed, 16 Dec 2020 10:24:13 -0500 Received: by mail-oo1-xc31.google.com with SMTP id o5so1978429oop.12 for ; Wed, 16 Dec 2020 07:24:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8SRN56yJfUQeD5MpqsTXAZPAKET25/vTh1oHQZp/0pk=; b=tXlT1cBV99T/ZEnUgz1/Ks5xPtvhUlvAmp2mEo4M1pvkxjGFpjGMpk/ftig2HNS3+M CFhq+5poMw9fRQ3F/90XvyDojohCuQ6gt4eUVA9MWCkGu6Sk3vi9HsOsjuBsamhy388/ TfL90PE9x78rj9W/soCq/9CEmZ2R1kq0wegFiEpOd4ZH7txdbwtLW6DdoKrBkhwOYXcy 4BIR6+DNSorFQUNLh4rS80FRWiOB0QenOJ9bFB5rwaEdSRnJBREER9o4pRRtijHJpXJc VlO//oYcV4mtCMI/O/D67Vs+xLMEfWsFiJiY7IQRWwP2s5Y7XOiriG1pVV/o46UVXl/X P3Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8SRN56yJfUQeD5MpqsTXAZPAKET25/vTh1oHQZp/0pk=; b=EWY9y9ariBRLZC1AMCXyxqKX6QH020LMaC+xdL4u2ZaUc9RqxR5jiwhyW/vYQHfElg FjcPzcIWwcDqBYwCUhGkDlwXKo+SnkTG60W3IX4jy6NpkkZJJnR4UGEeXeFwPGY2Qhpo 56vNQRDZBCw8sTQhtuoTUWPayn+adsy/51fM8GrUQYfg9ukh5GXU1USUbVojacchItZa RHJZHl+OLGEomn5PsZ0Fe0/f+xTagH4l0ay4yGOh4a6Tq2W/G/pScW18c6pBIFFvbvpX t2GNtplyiEuRAvM4pPgdQtTJD76LTeHQZNQNAlyIPiyg/JljYlnFtA5BBNm6J2bXY4wt kG6A== X-Gm-Message-State: AOAM531xL4PFxnkWYhqoDKssDxt59VUqxje86eMxYYonTwNVqGoWwfli 2YoejoUYYNHgTy9yejgIERUXYg== X-Google-Smtp-Source: ABdhPJycP7jJWscjxldyHdQFPMqcSOjc41xzmC+bdgNutptWRJODNOsbc6CI+IJovCXPATGby9ek+g== X-Received: by 2002:a4a:5590:: with SMTP id e138mr25668166oob.13.1608132250387; Wed, 16 Dec 2020 07:24:10 -0800 (PST) Received: from [10.10.121.52] (fixed-187-189-51-144.totalplay.net. [187.189.51.144]) by smtp.gmail.com with ESMTPSA id i25sm484709oto.56.2020.12.16.07.24.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Dec 2020 07:24:09 -0800 (PST) Subject: Re: [RFC v2 03/15] target/riscv: rvb: count bits set To: frank.chang@sifive.com, qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <20201216020150.3157-1-frank.chang@sifive.com> <20201216020150.3157-4-frank.chang@sifive.com> From: Richard Henderson Message-ID: Date: Wed, 16 Dec 2020 09:24:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201216020150.3157-4-frank.chang@sifive.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::c31; envelope-from=richard.henderson@linaro.org; helo=mail-oo1-xc31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , Kito Cheng , Alistair Francis , Palmer Dabbelt , Sagar Karandikar Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/15/20 8:01 PM, frank.chang@sifive.com wrote: > From: Frank Chang > > Signed-off-by: Kito Cheng > Signed-off-by: Frank Chang Reviewed-by: Richard Henderson > + return gen_unary(ctx, a, &tcg_gen_ctpop_tl); ... > + return gen_unary(ctx, a, &gen_pcntw); You can drop all of the unnecessary &'s. r~