[Qemu-devel] Re: [PATCH] Fix virtual console switching with SDL on Mac OS X

[Christian Walther <cwalther@gmx.ch>]

Jim C. Brown wrote:
> On Fri, Jul 22, 2005 at 11:24:21PM +0200, Christian Walther wrote:
> 
>>Has switching virtual consoles actually been broken with SDL on non-X11, 
>>non-win32 platforms (i.e. Mac OS X) for 7 months without anyone noticing 
>>?? Anyway, here's a patch that fixes it. Just a small change that was 
>>forgotten in the keymaps support (sdl.c rev. 1.20). Applies to current 
>>CVS as well as 0.7.0.
>>
>> -Christian
> 
> 
> Interesting.
> 
> Looks like the bug affects X11 and W32 as well, if you are not using a
> US keymap.

I don't think so. The non-keymap code that was used before my patch 
(sdl_keyevent_to_keycode()) uses event.key.keysym.scancode, which is 
platform-dependent, but refers to the location of the keys, not their 
value under the current keyboard mapping (apparently X keycodes on X11, 
PC keycodes on Windows, ADB keycodes on Mac OS). The with-keymap code 
(sdl_keyevent_to_keycode_generic()) on the other hand uses 
event.key.keysym.sym (one of the SDLK_xxx constants), which is affected 
by the OS's keyboard mapping. (Although IMHO it shouldn't be, but when 
that topic was brought up on the SDL mailing list, the answer IIRC was 
that that would be too difficult to fix on all platforms supported by 
SDL. I'm not convinced by that, but I didn't investigate any further at 
that time.)

It's just that in sdl_keyevent_to_keycode, the X11 and win32 cases are 
handled, but not the Mac OS case.

  -Christian