qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Claudio Fontana" <cfontana@suse.de>,
	"Thomas Huth" <thuth@redhat.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Roman Bolshakov" <r.bolshakov@yadro.com>,
	"Markus Armbruster" <armbru@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel@nongnu.org, haxm-team@intel.com,
	Wenchao Wang <wenchao.wang@intel.com>,
	Sunil Muthuswamy <sunilmut@microsoft.com>,
	Richard Henderson <rth@twiddle.net>,
	Colin Xu <colin.xu@intel.com>
Subject: Re: [RFC v2 3/6] cpus: extract out kvm-specific code to accel/kvm
Date: Tue, 7 Jul 2020 19:01:38 +0200	[thread overview]
Message-ID: <dc01dc35-c053-656c-72f5-87cad56706fb@redhat.com> (raw)
In-Reply-To: <20200707135808.9241-4-cfontana@suse.de>

On 07/07/20 15:58, Claudio Fontana wrote:
> +static void kvm_kick_vcpu_thread(CPUState *cpu)
> +{
> +    cpus_kick_thread(cpu);
> +}
> +

I would just use cpus_kick_thread instead of wrapping it (and likewise
would provide a global function for noop synchronization).

start_vcpu_thread is also a candidate for abstraction, so that
kvm_start_vcpu_thread(CPUState *cpu) would be just

	qemu_start_vcpu_thread(cpu, "KVM", kvm_vcpu_thread_fn);

Paolo



  reply	other threads:[~2020-07-07 17:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 13:58 [RFC v2 0/6] QEMU cpus.c refactoring part2 Claudio Fontana
2020-07-07 13:58 ` [RFC v2 1/6] cpus: extract out TCG-specific code to accel/tcg Claudio Fontana
2020-07-07 16:58   ` Paolo Bonzini
2020-07-08 14:30     ` Claudio Fontana
2020-07-07 13:58 ` [RFC v2 2/6] cpus: extract out qtest-specific code to accel/qtest Claudio Fontana
2020-07-07 13:58 ` [RFC v2 3/6] cpus: extract out kvm-specific code to accel/kvm Claudio Fontana
2020-07-07 17:01   ` Paolo Bonzini [this message]
2020-07-08  7:40     ` Claudio Fontana
2020-07-08  7:58       ` Paolo Bonzini
2020-07-07 13:58 ` [RFC v2 4/6] cpus: extract out hax-specific code to target/i386/ Claudio Fontana
2020-07-07 13:58 ` [RFC v2 5/6] cpus: extract out whpx-specific " Claudio Fontana
2020-07-07 13:58 ` [RFC v2 6/6] cpus: extract out hvf-specific code to target/i386/hvf/ Claudio Fontana
2020-07-07 15:03   ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc01dc35-c053-656c-72f5-87cad56706fb@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=cfontana@suse.de \
    --cc=colin.xu@intel.com \
    --cc=ehabkost@redhat.com \
    --cc=haxm-team@intel.com \
    --cc=lvivier@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=r.bolshakov@yadro.com \
    --cc=rth@twiddle.net \
    --cc=sunilmut@microsoft.com \
    --cc=thuth@redhat.com \
    --cc=wenchao.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).