From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54509)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1brMhx-0004HK-SC
	for qemu-devel@nongnu.org; Tue, 04 Oct 2016 06:12:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1brMht-0004mf-K3
	for qemu-devel@nongnu.org; Tue, 04 Oct 2016 06:12:20 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <598de7ff27e32fcb1b7f677f40fb8da4f0a1f512.1475434971.git.tgolembi@redhat.com>
	<20161004092405.GB5316@noname.str.redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <dc306851-88d9-d46c-82cc-b8eeca54578f@redhat.com>
Date: Tue, 4 Oct 2016 12:12:03 +0200
MIME-Version: 1.0
In-Reply-To: <20161004092405.GB5316@noname.str.redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>, =?UTF-8?B?VG9tw6HFoSBHb2xlbWJpb3Zza8O9?= <tgolembi@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>



On 04/10/2016 11:24, Kevin Wolf wrote:
> You also need to update the options for the blockdev-add QMP command in
> qapi/block-core.json. The relevant type is BlockdevOptionsFile.

Is it? Or should he define a new BlockdevOptionsRaw, and point to it in
the BlockdevOptions union instead of "'raw':
'BlockdevOptionsGenericFormat'"?

Paolo