From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E212CC2D0DB for ; Mon, 20 Jan 2020 16:51:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA04721835 for ; Mon, 20 Jan 2020 16:51:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VQFnTlfh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA04721835 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itaHM-0003PB-Px for qemu-devel@archiver.kernel.org; Mon, 20 Jan 2020 11:51:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34152) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itaGL-0002kg-Pg for qemu-devel@nongnu.org; Mon, 20 Jan 2020 11:51:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itaGI-0007Wn-59 for qemu-devel@nongnu.org; Mon, 20 Jan 2020 11:50:53 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:33525 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1itaGG-0007Ut-AQ for qemu-devel@nongnu.org; Mon, 20 Jan 2020 11:50:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579539047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FmE3GbIoW+xvZdd7VffdzwJiSNtsjHflViP75YRYDW0=; b=VQFnTlfh2Zj1f/IW3jtC19rUqMd/RiTJ9JAyLPWZUT+JwkVqgzKIlHdGTkrirtZr0ObOak 4htQOK67OyVjt3dfARHiZCorT5X2Ner+fckuad2hJiWCPJlKsaAe30jq/vN2dMVUQtIIix WyI6+tEiM6uiFKTNQQlBd0QV8U3UqGk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-307-bhapux0uPDa3MGJdDHrZBA-1; Mon, 20 Jan 2020 11:50:43 -0500 X-MC-Unique: bhapux0uPDa3MGJdDHrZBA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8655B100551A; Mon, 20 Jan 2020 16:50:42 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-117-225.ams2.redhat.com [10.36.117.225]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5603D5DDB3; Mon, 20 Jan 2020 16:50:40 +0000 (UTC) Subject: Re: [PATCH 1/2] block/backup-top: fix failure path To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org References: <20200116155452.30972-1-vsementsov@virtuozzo.com> <20200116155452.30972-2-vsementsov@virtuozzo.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: Date: Mon, 20 Jan 2020 17:50:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20200116155452.30972-2-vsementsov@virtuozzo.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mKSxRqeshz4StQloTx1d55izXhTXKqR5L" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mKSxRqeshz4StQloTx1d55izXhTXKqR5L Content-Type: multipart/mixed; boundary="NFApisACTCWO4cXXrZ38fs4iNxaZHjRkP" --NFApisACTCWO4cXXrZ38fs4iNxaZHjRkP Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 16.01.20 16:54, Vladimir Sementsov-Ogievskiy wrote: > We can't access top after call bdrv_backup_top_drop, as it is already > freed at this time. >=20 > Also, no needs to unref target child by hand, it will be unrefed on > bdrv_close() automatically. >=20 > So, just do bdrv_backup_top_drop if append succeed and one bdrv_unref > otherwise. >=20 > Note, that in !appended case bdrv_unref(top) moved into drained section > on source. It doesn't really matter, but just for code simplicity. >=20 > Fixes: 7df7868b96404 > Cc: qemu-stable@nongnu.org # v4.2.0 > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/backup-top.c | 21 ++++++++++++--------- > 1 file changed, 12 insertions(+), 9 deletions(-) Reviewed-by: Max Reitz --NFApisACTCWO4cXXrZ38fs4iNxaZHjRkP-- --mKSxRqeshz4StQloTx1d55izXhTXKqR5L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl4l2l4ACgkQ9AfbAGHV z0B6VggAlb2/WGn51iLUyD85SsRBmPFc6IrkpBkvogVYU14ILG3N000OgtSlU6h0 G8vgGPEhZfJgRoj0Vilh4Qys4p0t5R9Iyll52S5CFIyiQZT8JF0p4Qxg8+HrfKGB 12j2w1NHj/8bWmevrYM1b7tGXLlXfBE4L72F6W2JdAvnKFZvTAu4npCsW966Zw9B 9HCQ1e0D6ITdzdvwphsbe+53ayUhh9n7E5p/Hyx3Dbo0gettpATt+CZ/b9ZRzLlY 7Azh463AvrI9TIJxn3BFpm83qDZKtJ+OlQRhXyZfsN10wWBHVSfkOlfO/amCSVHN ajJaOkpnfgljb7Jbome2z5Y8RiZsUw== =M6ls -----END PGP SIGNATURE----- --mKSxRqeshz4StQloTx1d55izXhTXKqR5L--