From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Mikhail Tyutin" <m.tyutin@yadro.com>,
"Aleksandr Anenkov" <a.anenkov@yadro.com>,
qemu-devel@nongnu.org, "Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Bin Meng" <bin.meng@windriver.com>,
"Weiwei Li" <liweiwei@iscas.ac.cn>,
"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
"open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
"open list:PowerPC TCG CPUs" <qemu-ppc@nongnu.org>,
"open list:RISC-V TCG CPUs" <qemu-riscv@nongnu.org>
Subject: Re: [PATCH v11 12/18] hw/core/cpu: Remove gdb_get_dynamic_xml member
Date: Thu, 12 Oct 2023 15:45:59 +0200 [thread overview]
Message-ID: <dc65e5ae-42b0-db23-4d1d-1dc58275e2e3@linaro.org> (raw)
In-Reply-To: <20231012130616.7941-13-akihiko.odaki@daynix.com>
On 12/10/23 15:06, Akihiko Odaki wrote:
> This function is no longer used.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> include/hw/core/cpu.h | 4 ----
> target/arm/cpu.h | 6 ------
> target/ppc/cpu.h | 1 -
> target/arm/cpu.c | 1 -
> target/arm/gdbstub.c | 18 ------------------
> target/ppc/cpu_init.c | 3 ---
> target/ppc/gdbstub.c | 10 ----------
> target/riscv/cpu.c | 14 --------------
> 8 files changed, 57 deletions(-)
Shouldn't this patch follow "gdbstub: Simplify XML lookup",
before "gdbstub: Infer number of core registers from XML"?
Otherwise,
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-10-12 13:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 13:05 [PATCH v11 00/18] plugins: Allow to read registers Akihiko Odaki
2023-10-12 13:05 ` [PATCH v11 01/18] gdbstub: Add num_regs member to GDBFeature Akihiko Odaki
2023-10-12 13:05 ` [PATCH v11 02/18] gdbstub: Introduce gdb_find_static_feature() Akihiko Odaki
2023-10-12 13:05 ` [PATCH v11 03/18] gdbstub: Introduce GDBFeatureBuilder Akihiko Odaki
2023-10-12 13:05 ` [PATCH v11 04/18] target/arm: Use GDBFeature for dynamic XML Akihiko Odaki
2023-10-12 13:05 ` [PATCH v11 05/18] target/ppc: " Akihiko Odaki
2023-10-12 13:06 ` [PATCH v11 06/18] target/riscv: " Akihiko Odaki
2023-10-12 13:06 ` [PATCH v11 07/18] gdbstub: Use GDBFeature for gdb_register_coprocessor Akihiko Odaki
2023-10-12 13:06 ` [PATCH v11 08/18] gdbstub: Use GDBFeature for GDBRegisterState Akihiko Odaki
2023-10-12 13:06 ` [PATCH v11 09/18] gdbstub: Change gdb_get_reg_cb and gdb_set_reg_cb Akihiko Odaki
2023-10-12 13:40 ` Philippe Mathieu-Daudé
2023-10-12 13:06 ` [PATCH v11 10/18] gdbstub: Simplify XML lookup Akihiko Odaki
2023-10-12 13:06 ` [PATCH v11 11/18] gdbstub: Infer number of core registers from XML Akihiko Odaki
2023-10-12 13:43 ` Philippe Mathieu-Daudé
2023-10-12 14:45 ` Akihiko Odaki
2023-10-12 15:53 ` Philippe Mathieu-Daudé
2023-10-12 13:06 ` [PATCH v11 12/18] hw/core/cpu: Remove gdb_get_dynamic_xml member Akihiko Odaki
2023-10-12 13:45 ` Philippe Mathieu-Daudé [this message]
2023-10-12 13:06 ` [PATCH v11 13/18] gdbstub: Add members to identify registers to GDBFeature Akihiko Odaki
2023-10-12 13:06 ` [PATCH v11 14/18] gdbstub: Expose functions to read registers Akihiko Odaki
2023-10-12 13:06 ` [PATCH v11 15/18] cpu: Call plugin hooks only when ready Akihiko Odaki
2023-10-12 13:06 ` [PATCH v11 16/18] plugins: Use different helpers when reading registers Akihiko Odaki
2023-10-12 13:06 ` [PATCH v11 17/18] plugins: Allow to read registers Akihiko Odaki
2023-10-12 13:06 ` [PATCH v11 18/18] contrib/plugins: Allow to log registers Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc65e5ae-42b0-db23-4d1d-1dc58275e2e3@linaro.org \
--to=philmd@linaro.org \
--cc=a.anenkov@yadro.com \
--cc=akihiko.odaki@daynix.com \
--cc=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=eduardo@habkost.net \
--cc=liweiwei@iscas.ac.cn \
--cc=m.tyutin@yadro.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=wangyanan55@huawei.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).