From: Thomas Huth <huth@tuxfamily.org>
To: Michael Rolnik <mrolnik@gmail.com>, Thomas Huth <huth@tuxfamily.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Richard Henderson <rth@twiddle.net>,
Anichang <anichang@protonmail.ch>
Subject: Re: [Qemu-devel] [PATCH RFC v19 01/13] target-avr: AVR cores support is added.
Date: Wed, 14 Jun 2017 07:19:09 +0200 [thread overview]
Message-ID: <dc686f64-edf2-43df-318d-47b0c839c0e6@tuxfamily.org> (raw)
In-Reply-To: <CAK4993gCQsJKy-nK4NNS=+v3-zLhM8S5iyHnLUmjqHvFMEmzoA@mail.gmail.com>
On 13.06.2017 22:32, Michael Rolnik wrote:
> the last version of my patches were done by Richard. Now I just
> reapplied them to the master.
> Should I have to remove "signed-off-by Richard" ?
OK, if Richard did change to your patches, you should likely keep the
line. But I think you should remove the "Message-Id" line when sending
patches to the list, since that is normally only used by maintainers
when they finally pick up the patches. Otherwise this looks very
confusing (since the new v19 version has a different Message-Id in the
mail header).
Thomas
> On Tue, Jun 13, 2017 at 11:09 PM, Thomas Huth <huth@tuxfamily.org
> <mailto:huth@tuxfamily.org>> wrote:
>
> On 08.06.2017 20:49, Michael Rolnik wrote:
> > 1. basic CPU structure
> > 2. registers
> > 3. no instructions
> > 4. saving sreg, rampD, rampX, rampY, rampD, eind in HW representation
> >
> > Signed-off-by: Michael Rolnik <mrolnik@gmail.com <mailto:mrolnik@gmail.com>>
> > Message-Id: <1471522070-77598-2-git-send-email-mrolnik@gmail.com
> <mailto:1471522070-77598-2-git-send-email-mrolnik@gmail.com>>
> > Signed-off-by: Richard Henderson <rth@twiddle.net <mailto:rth@twiddle.net>>
>
> Why is the final "Signed-off-by" by Richard, if the patch has apparently
> been sent by you, Michael? Something is wrong here with the order...
>
> Thomas
next prev parent reply other threads:[~2017-06-14 5:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 18:49 [Qemu-devel] [PATCH RFC v19 00/13] QEMU AVR 8 bit cores Michael Rolnik
2017-06-08 18:49 ` [Qemu-devel] [PATCH RFC v19 01/13] target-avr: AVR cores support is added Michael Rolnik
2017-06-13 20:09 ` Thomas Huth
2017-06-13 20:32 ` Michael Rolnik
2017-06-14 5:19 ` Thomas Huth [this message]
2017-06-08 18:49 ` [Qemu-devel] [PATCH RFC v19 02/13] target-avr: adding AVR CPU features/flavors Michael Rolnik
2017-06-08 18:49 ` [Qemu-devel] [PATCH RFC v19 03/13] target-avr: adding a sample AVR board Michael Rolnik
2017-06-13 19:55 ` Thomas Huth
2017-06-08 18:49 ` [Qemu-devel] [PATCH RFC v19 04/13] target-avr: adding instructions encodings Michael Rolnik
2017-06-08 18:49 ` [Qemu-devel] [PATCH RFC v19 05/13] target-avr: adding AVR interrupt handling Michael Rolnik
2017-06-08 18:49 ` [Qemu-devel] [PATCH RFC v19 06/13] target-avr: adding helpers for IN, OUT, SLEEP, WBR & unsupported instructions Michael Rolnik
2017-06-08 18:49 ` [Qemu-devel] [PATCH RFC v19 07/13] target-avr: adding instruction translation Michael Rolnik
2017-06-08 18:49 ` [Qemu-devel] [PATCH RFC v19 08/13] target-avr: instruction decoder generator Michael Rolnik
2017-06-13 20:04 ` Thomas Huth
2017-06-08 18:49 ` [Qemu-devel] [PATCH RFC v19 09/13] target-avr: adding instruction decoder Michael Rolnik
2017-06-13 20:01 ` Thomas Huth
2017-06-13 20:29 ` Michael Rolnik
2017-06-14 5:14 ` Thomas Huth
2017-06-14 6:22 ` Michael Rolnik
2017-06-22 7:15 ` [Qemu-devel] [PATCH RFC v19 00/13] QEMU AVR 8 bit cores Michael Rolnik
2017-06-27 16:59 ` Anichang
2017-07-04 22:38 ` Richard Henderson
2017-07-05 6:34 ` Michael Rolnik
2017-07-05 15:59 ` Richard Henderson
2017-07-05 16:06 ` Michael Rolnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc686f64-edf2-43df-318d-47b0c839c0e6@tuxfamily.org \
--to=huth@tuxfamily.org \
--cc=anichang@protonmail.ch \
--cc=mrolnik@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).