From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58138)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pcacjr@zytor.com>) id 1YzPvO-00034T-Qk
	for qemu-devel@nongnu.org; Mon, 01 Jun 2015 09:38:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pcacjr@zytor.com>) id 1YzPvN-0004Iq-Gu
	for qemu-devel@nongnu.org; Mon, 01 Jun 2015 09:38:42 -0400
Received: from terminus.zytor.com ([2001:1868:205::10]:55834)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pcacjr@zytor.com>) id 1YzPvN-0004IP-7a
	for qemu-devel@nongnu.org; Mon, 01 Jun 2015 09:38:41 -0400
Message-ID: <dc7cb0e10e7159fd7c7fb5389820fecc.squirrel@www.zytor.com>
In-Reply-To: <556C2067.1030607@redhat.com>
References: <1432686576-14816-1-git-send-email-pcacjr@zytor.com>
	<1433023482-25721-1-git-send-email-pcacjr@zytor.com>
	<556C2067.1030607@redhat.com>
Date: Mon, 1 Jun 2015 10:38:32 -0300
From: "Paulo Alcantara" <pcacjr@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain;charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v2 1/3] ich9: add TCO interface emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: seabios@seabios.org, Paulo Alcantara <pcacjr@gmail.com>, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On Mon, June 1, 2015 6:05 am, Paolo Bonzini wrote:
>
>
> On 31/05/2015 00:04, Paulo Alcantara wrote:
>> +    case TCO_RLD:
>> +        tr->timeouts_no = 0;
>> +        if (can_start_tco_timer(tr)) {
>> +            tr->tco.rld = tr->tco.tmr;
>> +            tco_timer_reload(tr);
>> +        } else {
>> +            tr->tco.rld = val;
>
> Please mask out bits outside TCO_RLD_MASK here, same as you do for
> TCO1_STS_MASK and friends.

OK.

>> +        tr->tco.cnt1 = tr->tco.cnt1 & TCO_LOCK ? val | TCO_LOCK : val;
>
> Since you have to respin, you can do:
>
> 	tr->tco.cnt1 = val | (tr->tco.cnt1 & TCO_LOCK);

OK.

>
> Otherwise looks good to me.
>
> CCing the maintainer.

OK. Sorry for not CCing him earlier.

Thanks,

Paulo

-- 
Paulo Alcantara, C.E.S.A.R
Speaking for myself only.