From: Connor Kuehl <ckuehl@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH 0/2] net/tap: minor fixes to interaction with the bridge helper
Date: Tue, 11 May 2021 13:54:18 -0500 [thread overview]
Message-ID: <dc960526-bfe6-16ac-a9b0-8bf99a8aa4be@redhat.com> (raw)
In-Reply-To: <20210505121236.532755-1-berrange@redhat.com>
On 5/5/21 7:12 AM, Daniel P. Berrangé wrote:
> QEMU fails to report a good error message if the bridge helper exits
> with success code, but forgets to pass back an FD.
>
> There is also a minor portability problem impacting FreeBSD/NetBSD
> dealing with cmsg initialization.
>
> Daniel P. Berrangé (2):
> net/tap: fix FreeBSD portability problem receiving TAP FD
> net/tap: fix error reporting when bridge helper forgets to send an FD
>
> net/tap.c | 34 +++++++++++++++++++++++-----------
> 1 file changed, 23 insertions(+), 11 deletions(-)
>
Just a minor question on patch 2.
Otherwise, for the series:
Reviewed-by: Connor Kuehl <ckuehl@redhat.com>
prev parent reply other threads:[~2021-05-11 18:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 12:12 [PATCH 0/2] net/tap: minor fixes to interaction with the bridge helper Daniel P. Berrangé
2021-05-05 12:12 ` [PATCH 1/2] net/tap: fix FreeBSD portability problem receiving TAP FD Daniel P. Berrangé
2021-05-05 12:12 ` [PATCH 2/2] net/tap: fix error reporting when bridge helper forgets to send an FD Daniel P. Berrangé
2021-05-05 12:32 ` Philippe Mathieu-Daudé
2021-05-12 15:36 ` Daniel P. Berrangé
2021-05-11 18:53 ` Connor Kuehl
2021-05-12 15:34 ` Daniel P. Berrangé
2021-05-11 18:54 ` Connor Kuehl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc960526-bfe6-16ac-a9b0-8bf99a8aa4be@redhat.com \
--to=ckuehl@redhat.com \
--cc=berrange@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).