From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
Igor Mammedov <imammedo@redhat.com>,
Xiao Guangrong <xiaoguangrong.eric@gmail.com>
Subject: Re: [PATCH v3 09/10] memory-device: Refactor memory_device_pre_plug()
Date: Wed, 14 Jun 2023 14:27:38 +0200 [thread overview]
Message-ID: <dca0331c-66fb-1b38-8d45-1e5d7c118494@linaro.org> (raw)
In-Reply-To: <20230601121447.272487-11-david@redhat.com>
On 1/6/23 14:14, David Hildenbrand wrote:
> Let's move memory_device_check_addable() and basic checks out of
> memory_device_get_free_addr() directly into memory_device_pre_plug().
>
> Separating basic checks from address assignment is cleaner and
> prepares for further changes.
>
> As all memory device users now use memory_devices_init(), and that
> function enforces that the size is 0, we can drop the check for an empty
> region.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> hw/mem/memory-device.c | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-06-14 12:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 12:14 [PATCH] memory-device: Track used region size in DeviceMemoryState David Hildenbrand
2023-06-01 12:14 ` [PATCH v3 00/10] memory-device: Some cleanups David Hildenbrand
2023-06-14 9:10 ` David Hildenbrand
2023-06-01 12:14 ` [PATCH v3 01/10] memory-device: Unify enabled vs. supported error messages David Hildenbrand
2023-06-01 12:14 ` [PATCH v3 02/10] memory-device: Introduce machine_memory_devices_init() David Hildenbrand
2023-06-01 12:14 ` [PATCH v3 03/10] hw/arm/virt: Use machine_memory_devices_init() David Hildenbrand
2023-06-01 12:14 ` [PATCH v3 04/10] hw/ppc/spapr: " David Hildenbrand
2023-06-14 13:04 ` Cédric Le Goater
2023-06-01 12:14 ` [PATCH v3 05/10] hw/loongarch/virt: " David Hildenbrand
2023-06-01 12:14 ` [PATCH v3 06/10] hw/i386/pc: " David Hildenbrand
2023-06-01 12:14 ` [PATCH v3 07/10] hw/i386/acpi-build: Rely on machine->device_memory when building SRAT David Hildenbrand
2023-06-01 12:14 ` [PATCH v3 08/10] hw/i386/pc: Remove PC_MACHINE_DEVMEM_REGION_SIZE David Hildenbrand
2023-06-01 12:14 ` [PATCH v3 09/10] memory-device: Refactor memory_device_pre_plug() David Hildenbrand
2023-06-14 12:27 ` Philippe Mathieu-Daudé [this message]
2023-06-01 12:14 ` [PATCH v3 10/10] memory-device: Track used region size in DeviceMemoryState David Hildenbrand
2023-06-01 12:22 ` [PATCH] " David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dca0331c-66fb-1b38-8d45-1e5d7c118494@linaro.org \
--to=philmd@linaro.org \
--cc=david@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).