Re: [PATCH v2 1/4] ui: fix tab indentation

[Thomas Huth <thuth@redhat.com>]

On 18/10/2022 18.25, Amarjargal Gundjalam wrote:
> The TABs should be replaced with spaces, to make sure that we have a
> consistent coding style with an indentation of 4 spaces everywhere.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/370
> 
> Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com>

  Hi!

Thanks for tackling this! Some comments below...

> diff --git a/ui/vnc-enc-zywrle.h b/ui/vnc-enc-zywrle.h
> index 9b7f698975..f74ad81749 100644
> --- a/ui/vnc-enc-zywrle.h
> +++ b/ui/vnc-enc-zywrle.h
> @@ -51,14 +51,14 @@ static const unsigned int zywrle_param[3][3]={
>           {0x0000F000, 0x00000000, 0x00000000},
>           {0x0000C000, 0x00F0F0F0, 0x00000000},
>           {0x0000C000, 0x00C0C0C0, 0x00F0F0F0},
> -/*	{0x0000FF00, 0x00000000, 0x00000000},
> +/*    {0x0000FF00, 0x00000000, 0x00000000},

I think this curly brace was meant to be aligned with the other curly braces 
above and below ... could you add some spaces?

>           {0x0000FF00, 0x00FFFFFF, 0x00000000},
>           {0x0000FF00, 0x00FFFFFF, 0x00FFFFFF}, */
>   };
>   #else
>   /* Type B:Non liner quantization filter. */
>   static const int8_t zywrle_conv[4][256]={
> -{	/* bi=5, bo=5 r=0.0:PSNR=24.849 */
> +{    /* bi=5, bo=5 r=0.0:PSNR=24.849 */

This likely was also meant to be aligned with the numbers below... could you 
add some spaces?

Same applies for the other "bi=5" comments that you've changed.

  Thomas