From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmP8y-0006cY-GT for qemu-devel@nongnu.org; Tue, 20 Sep 2016 13:47:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmP8u-0006bL-9E for qemu-devel@nongnu.org; Tue, 20 Sep 2016 13:47:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmP8t-0006am-WC for qemu-devel@nongnu.org; Tue, 20 Sep 2016 13:47:40 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 74ED08E3DF for ; Tue, 20 Sep 2016 17:47:39 +0000 (UTC) References: <20160913130209.695-1-marcandre.lureau@redhat.com> <20160913130209.695-2-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: Date: Tue, 20 Sep 2016 12:47:38 -0500 MIME-Version: 1.0 In-Reply-To: <20160913130209.695-2-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LcWMPVrmxC0X2PH9mLVKjqUUaE8pDuHme" Subject: Re: [Qemu-devel] [PATCH 01/30] qmp-commands: move 'add_client' doc to schema List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , qemu-devel@nongnu.org Cc: armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LcWMPVrmxC0X2PH9mLVKjqUUaE8pDuHme From: Eric Blake To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , qemu-devel@nongnu.org Cc: armbru@redhat.com Message-ID: Subject: Re: [PATCH 01/30] qmp-commands: move 'add_client' doc to schema References: <20160913130209.695-1-marcandre.lureau@redhat.com> <20160913130209.695-2-marcandre.lureau@redhat.com> In-Reply-To: <20160913130209.695-2-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/13/2016 08:01 AM, Marc-Andr=C3=A9 Lureau wrote: > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > docs/qmp-commands.txt | 18 ------------------ > qapi-schema.json | 8 ++++++++ > 2 files changed, 8 insertions(+), 18 deletions(-) >=20 > diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt We're trimming off more than we move; but the trimmed stuff is duplicate once it is all in one file in one location. I'm liking the overall theme of the consolidation. This series will probably conflict with other pending changes in the tree, so we should probably get it in sooner rather than later. Reviewed-by: Eric Blake For the next few patches, I'll probably just do a bulk R-b unless specific issues pop out while I read through them. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LcWMPVrmxC0X2PH9mLVKjqUUaE8pDuHme Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX4XY6AAoJEKeha0olJ0NqvKgH/0gC69WUmRwPgCkmgMKAEq3Z E/p+QUd1zOhpn+kjOs9h1jUqgG0TSsXwk/RQAE7lWUhGDBDqdUNh1yjiD/DVbTxh q68wRhJSOldqRlUbRHqUWgvapMIlU4zklKQ/JBNmQseYQnQURnW4jxpSxLEJ4fbp HqpxkiRTA0+6cq/n6CcgL9zps/bIoIy2RNBzK0FI/O8DGYTr4uvoTluSOjlzn6Mn zDEhvkpb9VrWT2gu/e8s2+y+lM6NPYriRqDxDuoiXXYqKjf5w4U6QuP8CRzh4ESi 9EU/UHXeQONOrYMHxFBkDnaQdJevNSOW0e0tuo19xo7zBCBr/Bi7AqNTG9Vvu6w= =5UZn -----END PGP SIGNATURE----- --LcWMPVrmxC0X2PH9mLVKjqUUaE8pDuHme--