From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, jcody@redhat.com, jsnow@redhat.com
Subject: Re: [Qemu-devel] [PATCH 03/10] blockjob: introduce block_job_fail
Date: Tue, 11 Apr 2017 12:00:36 +0800 [thread overview]
Message-ID: <dcc280a6-ee64-38d9-512d-24a2be8e566a@redhat.com> (raw)
In-Reply-To: <20170410092255.GD2567@stefanha-x1.localdomain>
On 10/04/2017 17:22, Stefan Hajnoczi wrote:
>>
>> Later on, block_job_fail will also have different locking than
>> block_job_unref.
> block_job_fail() sounds like it's *the* job failure API.
> How about block_job_fail_early()?
>
> It indicates the API is only for the beginning of the job's lifecycle.
Can't disagree and I'll apply your suggestion. Thanks,
Paolo
next prev parent reply other threads:[~2017-04-11 8:57 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 17:39 [Qemu-devel] [PATCH for-2.10 00/10] Preparation for block job mutex Paolo Bonzini
2017-03-23 17:39 ` [Qemu-devel] [PATCH 01/10] blockjob: remove unnecessary check Paolo Bonzini
2017-04-07 22:30 ` John Snow
2017-04-07 22:54 ` Philippe Mathieu-Daudé
2017-04-07 23:16 ` John Snow
2017-04-10 9:27 ` Stefan Hajnoczi
2017-03-23 17:39 ` [Qemu-devel] [PATCH 02/10] blockjob: remove iostatus_reset callback Paolo Bonzini
2017-04-07 23:12 ` John Snow
2017-04-08 0:18 ` Philippe Mathieu-Daudé
2017-04-10 9:27 ` Stefan Hajnoczi
2017-03-23 17:39 ` [Qemu-devel] [PATCH 03/10] blockjob: introduce block_job_fail Paolo Bonzini
2017-04-07 23:24 ` John Snow
2017-04-10 9:22 ` Stefan Hajnoczi
2017-04-11 4:00 ` Paolo Bonzini [this message]
2017-03-23 17:39 ` [Qemu-devel] [PATCH 04/10] blockjob: introduce block_job_pause/resume_all Paolo Bonzini
2017-04-07 23:37 ` John Snow
2017-04-10 9:26 ` Stefan Hajnoczi
2017-03-23 17:39 ` [Qemu-devel] [PATCH 05/10] blockjob: separate monitor and blockjob APIs Paolo Bonzini
2017-04-08 0:03 ` John Snow
2017-04-08 9:52 ` Paolo Bonzini
2017-04-10 16:05 ` John Snow
2017-04-11 4:57 ` Paolo Bonzini
2017-04-11 16:19 ` John Snow
2017-04-10 9:30 ` Stefan Hajnoczi
2017-03-23 17:39 ` [Qemu-devel] [PATCH 06/10] blockjob: move iostatus reset inside block_job_user_resume Paolo Bonzini
2017-04-08 0:28 ` John Snow
2017-04-10 9:33 ` Stefan Hajnoczi
2017-03-23 17:39 ` [Qemu-devel] [PATCH 07/10] blockjob: strengthen a bit test-blockjob-txn Paolo Bonzini
2017-04-08 0:37 ` John Snow
2017-04-10 9:35 ` Stefan Hajnoczi
2017-03-23 17:39 ` [Qemu-devel] [PATCH 08/10] blockjob: introduce block_job_cancel_async Paolo Bonzini
2017-04-08 1:13 ` John Snow
2017-04-08 9:54 ` Paolo Bonzini
2017-04-10 9:36 ` Stefan Hajnoczi
2017-03-23 17:39 ` [Qemu-devel] [PATCH 09/10] blockjob: reorganize block_job_completed_txn_abort Paolo Bonzini
2017-04-08 1:15 ` John Snow
2017-04-08 10:03 ` Paolo Bonzini
2017-04-10 9:44 ` Stefan Hajnoczi
2017-04-10 19:17 ` John Snow
2017-04-11 4:11 ` Paolo Bonzini
2017-03-23 17:39 ` [Qemu-devel] [PATCH 10/10] blockjob: use deferred_to_main_loop to indicate the coroutine has ended Paolo Bonzini
2017-04-08 1:32 ` John Snow
2017-04-08 9:56 ` Paolo Bonzini
2017-04-10 9:46 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcc280a6-ee64-38d9-512d-24a2be8e566a@redhat.com \
--to=pbonzini@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).