From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9051EC3064D for ; Fri, 28 Jun 2024 08:05:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sN6c2-0004cR-SA; Fri, 28 Jun 2024 04:05:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sN6c0-0004JC-5M for qemu-devel@nongnu.org; Fri, 28 Jun 2024 04:05:40 -0400 Received: from mail.ozlabs.org ([2404:9400:2221:ea00::3]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sN6by-0007Sc-5r for qemu-devel@nongnu.org; Fri, 28 Jun 2024 04:05:39 -0400 Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4W9Sfm1MSXz4w2Q; Fri, 28 Jun 2024 18:05:36 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4W9Sfl1Gtxz4w2N; Fri, 28 Jun 2024 18:05:34 +1000 (AEST) Message-ID: Date: Fri, 28 Jun 2024 10:05:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [SPAM] [PATCH v42 78/98] hw/sd/sdcard: Remove default case in read/write on DAT lines To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org References: <20240628070216.92609-1-philmd@linaro.org> <20240628070216.92609-79-philmd@linaro.org> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= In-Reply-To: <20240628070216.92609-79-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2404:9400:2221:ea00::3; envelope-from=SRS0=GU6n=N6=kaod.org=clg@ozlabs.org; helo=mail.ozlabs.org X-Spam_score_int: -39 X-Spam_score: -4.0 X-Spam_bar: ---- X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: > All read/write on DAT lines are explicitly handled. > Reaching this point would be a programming error: > replace by an assertion. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/sd/sd.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/hw/sd/sd.c b/hw/sd/sd.c > index 0a7b422b2c..64621d4340 100644 > --- a/hw/sd/sd.c > +++ b/hw/sd/sd.c > @@ -1951,7 +1951,6 @@ int sd_do_command(SDState *sd, SDRequest *req, > /* Valid command, we can update the 'state before command' bits. > * (Do this now so they appear in r1 responses.) > */ > - sd->current_cmd = req->cmd; > sd->card_status = FIELD_DP32(sd->card_status, CSR, > CURRENT_STATE, last_state); > } > @@ -2016,6 +2015,8 @@ send_response: > qemu_hexdump(stderr, "Response", response, rsplen); > #endif > > + sd->current_cmd = rtype == sd_illegal ? 0 : req->cmd; > + > return rsplen; > } > > @@ -2171,8 +2172,7 @@ void sd_write_byte(SDState *sd, uint8_t value) > break; > > default: > - qemu_log_mask(LOG_GUEST_ERROR, "%s: unknown command\n", __func__); > - break; > + g_assert_not_reached(); > } > } > > @@ -2238,8 +2238,7 @@ uint8_t sd_read_byte(SDState *sd) > break; > > default: > - qemu_log_mask(LOG_GUEST_ERROR, "%s: unknown command\n", __func__); > - return 0x00; > + g_assert_not_reached(); > } > > return ret;