From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
qemu-arm@nongnu.org, qemu-trivial@nongnu.org,
Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [PATCH 4/5] hw/i2c/bitbang_i2c: Trace state changes
Date: Tue, 10 Jan 2023 09:26:27 +0100 [thread overview]
Message-ID: <dd03766f-e4f0-03f6-de16-0d4f9ed8b0ed@linaro.org> (raw)
In-Reply-To: <55413dee-6141-2f36-ed8f-964df43aa578@linaro.org>
On 9/1/23 17:07, Richard Henderson wrote:
> On 1/9/23 00:41, Philippe Mathieu-Daudé wrote:
>> + NAME(WAITING_FOR_ACK),
>> + [RECEIVING_BIT7] = "RECEIVING_BIT7 (ACK)",
>> + NAME(RECEIVING_BIT7),
>
> You've overwritten your special case.
Oops good catch.
> Otherwise,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Thanks!
next prev parent reply other threads:[~2023-01-10 9:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 8:41 [PATCH 0/5] hw/i2c/bitbang_i2c: Housekeeping Philippe Mathieu-Daudé
2023-01-09 8:41 ` [PATCH 1/5] hw/i2c/bitbang_i2c: Define TYPE_GPIO_I2C in public header Philippe Mathieu-Daudé
2023-01-09 16:04 ` Richard Henderson
2023-01-09 8:41 ` [PATCH 2/5] hw/i2c/bitbang_i2c: Remove unused dummy MemoryRegion Philippe Mathieu-Daudé
2023-01-09 16:05 ` Richard Henderson
2023-01-09 8:41 ` [PATCH 3/5] hw/i2c/bitbang_i2c: Change state calling bitbang_i2c_set_state() helper Philippe Mathieu-Daudé
2023-01-09 16:07 ` Richard Henderson
2023-01-09 8:41 ` [PATCH 4/5] hw/i2c/bitbang_i2c: Trace state changes Philippe Mathieu-Daudé
2023-01-09 16:07 ` Richard Henderson
2023-01-10 8:26 ` Philippe Mathieu-Daudé [this message]
2023-01-09 8:41 ` [PATCH 5/5] hw/i2c/bitbang_i2c: Convert DPRINTF() to trace events Philippe Mathieu-Daudé
2023-01-09 16:10 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd03766f-e4f0-03f6-de16-0d4f9ed8b0ed@linaro.org \
--to=philmd@linaro.org \
--cc=jan.kiszka@web.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).