From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89B66C6FD18 for ; Wed, 19 Apr 2023 05:42:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pp0Zz-00037d-0D; Wed, 19 Apr 2023 01:42:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pp0Zx-00037N-1E for qemu-devel@nongnu.org; Wed, 19 Apr 2023 01:42:05 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pp0Zv-0005SW-4m for qemu-devel@nongnu.org; Wed, 19 Apr 2023 01:42:04 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3f18123da10so655145e9.1 for ; Tue, 18 Apr 2023 22:42:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681882920; x=1684474920; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=csLUvFkt2vrtm4GGPAxkC4u0kZAPXWdY2HFAG+g4HCg=; b=lyAs45kMx+Fhm77Uier1wYcX290FpF8A+z5E0LQNGUshDOVcrkNrHgphFerOtL7fAe XsfwZKvg9pCk41hkHotLMCguIxT0nOQL5IJHsprkBgZWRAbuSxXv93bOCwwS75iA8hTY P8NgVJ1GiPSguW4GVdKf9lVePn4HjqZusTHHfO5aX6OjTphf7JB93UEgGddG9SU0i5Qj Zui7gIPqDl4NPT/LIbUqhvEvRDfz+HdhZBb0xlA9a2X90HVvO3bbydhKz0k4iR5soJdK lpad3wgImMnqnVns5YezQxiA4/2YUI7uA6S+jnIv0x9EOkoT4IQundimoOc0aUS7vimA ci9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681882920; x=1684474920; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=csLUvFkt2vrtm4GGPAxkC4u0kZAPXWdY2HFAG+g4HCg=; b=e2blv+p612ZXTwRTtyl1kGKVl+n9VdRCQeKNYX3w5HlUrdM1j/MpLfyamb3t1X4ut8 0g2HvdW7CsU1ZBNlyJAZmpjQGiEmg6MNoD3W+zIDAX9nlhLVfq5FAe2wEIoAU1/jHSfq F6v69zvJGiZsQygd9bUUpbL7aGoDPVLA/Hpau5GVLed79H9PCPJe//b+5V5WMrnzRZHd 3NbI/bAorb9d7WHIlJgikJjjVelvRgr7kF290cJzjpK7VKIKIryFhSpGa7mRO4aOJIqR pioeFgpwrk6AXeun9Dufz/1gEdy3i5PtgD7GSyDcQZ8EK7TNfdu+FzSNA8KVY5ZO/LPE GkEw== X-Gm-Message-State: AAQBX9fJNsDvilh+CQNl3w4FNIMxQQcDp7WxYebH9CdsPN29Uc3FISVM YzmfwgW3p/CA5098bSuBOVLcsQ== X-Google-Smtp-Source: AKy350YFNfO8gTmrGZ3S8diMlWOTB91Ii6tn2CqRNBgXmjOTFBMs18z2uBi257V5896IrInNEdzbtg== X-Received: by 2002:a5d:51d2:0:b0:2fa:f8c2:45f4 with SMTP id n18-20020a5d51d2000000b002faf8c245f4mr4135973wrv.0.1681882919896; Tue, 18 Apr 2023 22:41:59 -0700 (PDT) Received: from [192.168.58.227] (103.red-83-56-31.staticip.rima-tde.net. [83.56.31.103]) by smtp.gmail.com with ESMTPSA id 4-20020a05600c228400b003f17e79d74asm1012272wmf.7.2023.04.18.22.41.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 22:41:59 -0700 (PDT) Message-ID: Date: Wed, 19 Apr 2023 07:41:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 6/8] accel/tcg: Uncache the host address for instruction fetch when tlb size < 1 Content-Language: en-US To: Weiwei Li , qemu-riscv@nongnu.org, qemu-devel@nongnu.org Cc: palmer@dabbelt.com, alistair.francis@wdc.com, bin.meng@windriver.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, wangjunqiang@iscas.ac.cn, lazyparser@gmail.com References: <20230418140632.53166-1-liweiwei@iscas.ac.cn> <20230418140632.53166-7-liweiwei@iscas.ac.cn> From: Richard Henderson In-Reply-To: <20230418140632.53166-7-liweiwei@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -46 X-Spam_score: -4.7 X-Spam_bar: ---- X-Spam_report: (-4.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.597, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 4/18/23 16:06, Weiwei Li wrote: > When PMP entry overlap part of the page, we'll set the tlb_size to 1, which > will make the address in tlb entry set with TLB_INVALID_MASK, and the next > access will again go through tlb_fill.However, this way will not work in > tb_gen_code() => get_page_addr_code_hostp(): the TLB host address will be > cached, and the following instructions can use this host address directly > which may lead to the bypass of PMP related check. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > --- > accel/tcg/cputlb.c | 5 +++++ > 1 file changed, 5 insertions(+) Reviewed-by: Richard Henderson r~