From: Paolo Bonzini <pbonzini@redhat.com>
To: Mirela Grujic <mirela.grujic@greensocs.com>, qemu-devel@nongnu.org
Cc: damien.hedde@greensocs.com, edgar.iglesias@xilinx.com,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
mark.burton@greensocs.com,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Eric Auger" <eric.auger@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls
Date: Fri, 14 May 2021 23:14:23 +0200 [thread overview]
Message-ID: <dd18ebb7-9583-86b8-e368-afef3b71e5ef@redhat.com> (raw)
In-Reply-To: <164d41e2-262f-0dab-17d6-c280428687cd@greensocs.com>
On 14/05/21 15:13, Mirela Grujic wrote:
> However, if you believe it should rather be just renamed I can do so.
I am just not sure it's such an advantage to replace phase_check with
separate functions. The rename is a constraint of QAPI, so we have to
live with the long names.
Paolo
next prev parent reply other threads:[~2021-05-14 21:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 8:25 [RFC PATCH 0/9] Initial support for machine creation via QMP Mirela Grujic
2021-05-13 8:25 ` [RFC PATCH 1/9] vl: Allow finer control in advancing machine through phases Mirela Grujic
2021-05-13 8:25 ` [RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls Mirela Grujic
2021-05-13 17:46 ` Paolo Bonzini
2021-05-14 13:13 ` Mirela Grujic
2021-05-14 21:14 ` Paolo Bonzini [this message]
2021-06-07 16:03 ` Eric Blake
2021-05-13 8:25 ` [RFC PATCH 3/9] rename MachineInitPhase enumeration constants Mirela Grujic
2021-05-13 8:25 ` [RFC PATCH 4/9] qapi: Implement 'query-machine-phase' command Mirela Grujic
2021-05-13 17:44 ` Paolo Bonzini
2021-05-19 15:43 ` Daniel P. Berrangé
2021-05-13 8:25 ` [RFC PATCH 5/9] qapi: Implement 'next-machine-phase' command Mirela Grujic
2021-06-04 14:25 ` Eric Blake
2021-06-05 14:40 ` Paolo Bonzini
2021-05-13 8:25 ` [RFC PATCH 6/9] qapi: Implement 'advance-machine-phase' command Mirela Grujic
2021-05-19 15:37 ` Kevin Wolf
2021-05-13 8:25 ` [RFC PATCH 7/9] qdev-monitor: Restructure and fix the check for command availability Mirela Grujic
2021-05-13 17:43 ` Paolo Bonzini
2021-05-14 13:00 ` Mirela Grujic
2021-05-13 8:25 ` [RFC PATCH 8/9] qapi: Introduce 'allow-init-config' option Mirela Grujic
2021-05-13 8:25 ` [RFC PATCH 9/9] qapi: Allow some commands to be executed in machine 'initialized' phase Mirela Grujic
2021-05-13 17:52 ` [RFC PATCH 0/9] Initial support for machine creation via QMP Paolo Bonzini
2021-05-14 12:48 ` Mirela Grujic
2021-05-14 16:00 ` Paolo Bonzini
2021-05-14 16:20 ` Daniel P. Berrangé
2021-05-14 18:32 ` Paolo Bonzini
2021-05-24 17:20 ` Igor Mammedov
2021-05-24 19:05 ` Igor Mammedov
2021-05-21 11:32 ` Markus Armbruster
2021-05-21 17:02 ` Paolo Bonzini
2021-05-21 14:06 ` Mirela Grujic
2021-05-21 16:57 ` Paolo Bonzini
2021-05-24 18:27 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd18ebb7-9583-86b8-e368-afef3b71e5ef@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=damien.hedde@greensocs.com \
--cc=dgilbert@redhat.com \
--cc=edgar.iglesias@xilinx.com \
--cc=ehabkost@redhat.com \
--cc=eric.auger@redhat.com \
--cc=kraxel@redhat.com \
--cc=mark.burton@greensocs.com \
--cc=mirela.grujic@greensocs.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).