From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 056A0C606C7 for ; Mon, 8 Jul 2019 19:18:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF84A217D6 for ; Mon, 8 Jul 2019 19:18:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF84A217D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkZ9i-0003dP-30 for qemu-devel@archiver.kernel.org; Mon, 08 Jul 2019 15:18:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33442) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkZ6a-0002it-L9 for qemu-devel@nongnu.org; Mon, 08 Jul 2019 15:15:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkZ6Z-0007TP-MG for qemu-devel@nongnu.org; Mon, 08 Jul 2019 15:15:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39106) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hkZ6X-0007QB-CB; Mon, 08 Jul 2019 15:15:13 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 45633E3E08; Mon, 8 Jul 2019 19:15:12 +0000 (UTC) Received: from [10.3.116.78] (ovpn-116-78.phx2.redhat.com [10.3.116.78]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 96EAA5C219; Mon, 8 Jul 2019 19:15:11 +0000 (UTC) To: Kevin Wolf References: <20190705152812.26438-1-eblake@redhat.com> <20190708165112.GA14296@linux.fritz.box> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: Date: Mon, 8 Jul 2019 14:15:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190708165112.GA14296@linux.fritz.box> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="240tCPFZRpnmYcVxAFCDYl4pLzldhCYzT" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 08 Jul 2019 19:15:12 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH for-4.1] qcow2: Allow -o compat=v3 during qemu-img amend X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, "open list:qcow2" , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --240tCPFZRpnmYcVxAFCDYl4pLzldhCYzT Content-Type: multipart/mixed; boundary="C6Tae2Cwq6p5hTYVR8GUxz9TWQYJH9Oq7"; protected-headers="v1" From: Eric Blake To: Kevin Wolf Cc: qemu-devel@nongnu.org, Max Reitz , "open list:qcow2" Message-ID: Subject: Re: [PATCH for-4.1] qcow2: Allow -o compat=v3 during qemu-img amend References: <20190705152812.26438-1-eblake@redhat.com> <20190708165112.GA14296@linux.fritz.box> In-Reply-To: <20190708165112.GA14296@linux.fritz.box> --C6Tae2Cwq6p5hTYVR8GUxz9TWQYJH9Oq7 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 7/8/19 11:51 AM, Kevin Wolf wrote: > Am 05.07.2019 um 17:28 hat Eric Blake geschrieben: >> Commit b76b4f60 allowed '-o compat=3Dv3' as an alias for the >> less-appealing '-o compat=3D1.1' for 'qemu-img create' since we want t= o >> use the QMP form as much as possible, but forgot to do likewise for >> qemu-img amend. Also, it doesn't help that '-o help' doesn't list our= >> new preferred spellings. >> >> Signed-off-by: Eric Blake >=20 > This broke qemu-iotests 082. Please send a follow-up to update the > reference output. I know that I did not specifically run iotests explicitly for this one patch, but thought I had at least ran 'make check', since I know we've been improving lately to run at least some of the iotests. /me goes and rechecks... well, 82 is definitely marked 'auto', and group claims that auto tests will be run by 'make check', but that didn't trigger the failure for me. I wonder why? At least I've posted the fix, as requested. --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --C6Tae2Cwq6p5hTYVR8GUxz9TWQYJH9Oq7-- --240tCPFZRpnmYcVxAFCDYl4pLzldhCYzT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAl0jlj4ACgkQp6FrSiUn Q2qFrggAgkCbPR+AIBQjXNhi+tAR5V1ECt98AmsfDjRAIdsFecoPSwaCip2lMpsk 7RsLDE+FLnRZtA6XII7MUv/0uN+ruMTJLsD/nFAofrEwUKYR7TzKSYo1uZfSHMdi CFcDstmbO39hDubsRpxIgOytQrSHOhzFVjhQOsxlnCIJyUhWLYhB1Xvxh4AkPVA6 b4Uoa91HusoWRzA0/zDo/yjdAreSWQAA3eL6/pI4aNIKw0SArSR0LABU0+FxWSU+ vKpoaTEtTQ75mYRlXgl6R4+HvZQbNAtOuJHSJOPBP5Y/mcJDDE361grUyadW3za1 aKZZaNVJUj8+XmqOdVxkW7ZMSOBnTw== =ptor -----END PGP SIGNATURE----- --240tCPFZRpnmYcVxAFCDYl4pLzldhCYzT--