From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 344B8CCFA13 for ; Mon, 10 Nov 2025 23:39:22 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vIbSl-0006l9-0W; Mon, 10 Nov 2025 18:38:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vIbSg-0006Z6-TY for qemu-devel@nongnu.org; Mon, 10 Nov 2025 18:38:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vIbSe-0001Cu-Om for qemu-devel@nongnu.org; Mon, 10 Nov 2025 18:38:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762817891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OMfGZ9JUUjIJMPY42nsl9O57la6VHKpSzHEkgK6kXss=; b=JtsOP3ZaS7ffCC2zZAkNkWNqgTsbGTm8Ej3BgEhP6ZQIXjfyaIqwbmS84FzItZSlUXZPnM JRLiz0JMiLjvPjEeNYr+BESm7hj1n/bM+p8aYoATCWcBciOa18PxqtE6sxoOW0/rz+TmBA bWZbiYsUGnryuSl0n/9zZhw2zq4jBcI= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-522-ObLZ1jRmPTGjU-W1mB8McA-1; Mon, 10 Nov 2025 18:38:09 -0500 X-MC-Unique: ObLZ1jRmPTGjU-W1mB8McA-1 X-Mimecast-MFC-AGG-ID: ObLZ1jRmPTGjU-W1mB8McA_1762817889 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-295b713530cso42279015ad.1 for ; Mon, 10 Nov 2025 15:38:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1762817888; x=1763422688; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OMfGZ9JUUjIJMPY42nsl9O57la6VHKpSzHEkgK6kXss=; b=AjEBXCANPPVDWLd1OIoTKM5UtU9AcRXRObfi5L3mgt++jBGPj8R6FZn9jFx1CmP57U JaXxFbo5xtsmilutU9HBpfqdzYMq9DAEU+V47r+fuLJ6fPRxXabfPN0ywqkLnc4+VKbi T2eubdUJcMH1PtD+aHh/UxHCY2jZE74kOh5ILD8fu7rMTM94GL2LdVBInm1Qhep2+Hoi BANTL8rnXwZcSSVV7hrJ352n1pK63bqaoCUKOrRojxI6vGeSBq1ERp/YzJA7WgjdiUmW l4lcNXDxI2VeK5a8cYHKZNDKBv7dCdJTWhGQlSn8AUjot6zQnu/S405H5EfxcfOEHR+h FDiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762817888; x=1763422688; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OMfGZ9JUUjIJMPY42nsl9O57la6VHKpSzHEkgK6kXss=; b=QqtFAiilGGkSnx0KfWxU1Z4aql0YzEVfbybK3iIbKH3Cxhe0QK+oH8VaO7mNb+zBAX eHijWJU+ELVxO4u9PqbdJzlheIguNzDs+w1r2+4z9adT2v91Eynke1kgkGOwHslMALw4 LERAW1x5NAzsMwPHq4HxOPaprI1oxz2FBAHCQXo56emdteklTS4cJHQHVaoOTjL1a+4T IP+G5izZt+s3/NofUnB0wxK9jYE/VCHYfmjiDdCiEWSloIRQyXxksJlOCiFz4INhLzTH g5pgkc66ZVTRqcXk1ApgBP2MpbZKvrgQDH7YkxJPvyI6L1EKkersi073nUs7hMdOYSSF Tv2g== X-Gm-Message-State: AOJu0YxUY9K5cvBFeXjgMWabR6ag4Q+3SuKd/c2Yj2U+i31f1HnmZTC8 90lJJf5gHIfnwmy4m3FYbK9DKyVP6j3zChc/n0GIshbEs7MJUZIGir7i6c1jg6AMl5qxFZ9/QK/ yK+lcocYyVbkBF+Grrv6SxJZ/SXk4BmAdaF01JWEEGbbuSjZOLcYHgt3O X-Gm-Gg: ASbGnct0qKYLWhVGUbnQ0VMErJkkUWjnbbDBWPs0StWQ07OGZuqnSXKJDsH//We9JJm T1zZ9OrSciUlTX2yJFK5a1RbPju8sy2Zj3u37bw3PkCactFSRkvn1SfN+oWIPQ6PGNaIeOeK16p bv65cSvYsaPiswz1/9RvodObkHPrcFXxAB2IvbkGZ2Wq/iUWnOU9zkRs/r3ltlMBsjKD69sLlOs k7U7CP7qOPcZG8SjBRr88XJW9OH80unXl8GTIzi1TIMCGGn2quhO5FigEiUSfPlFW07mHrGg0rr gY1bQQQEzOAqvwOVsU+pJcMARhAeVryWgYDCVRvxDBoxzKN4O5vFOWtqNjn5H+CTcqaCZ2TNxTg vFuzPoZNPMgg0O3KJZVRdqUV30rNP/jgZrrAtq6g= X-Received: by 2002:a17:902:e950:b0:295:c2e8:dabd with SMTP id d9443c01a7336-297e5658095mr139238205ad.26.1762817888615; Mon, 10 Nov 2025 15:38:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IHr5BSSyD+L9BwPc+iT4bCBSEwgoUH160ZjyP5iJc3IIRx84V4pKWAlO2KetLqY79WgzURItQ== X-Received: by 2002:a17:902:e950:b0:295:c2e8:dabd with SMTP id d9443c01a7336-297e5658095mr139237775ad.26.1762817887878; Mon, 10 Nov 2025 15:38:07 -0800 (PST) Received: from [192.168.68.51] (n175-34-62-5.mrk21.qld.optusnet.com.au. [175.34.62.5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2965096b8ffsm157920595ad.21.2025.11.10.15.38.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Nov 2025 15:38:07 -0800 (PST) Message-ID: Date: Tue, 11 Nov 2025 09:38:01 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/8] acpi/ghes: Extend acpi_ghes_memory_errors() to support multiple CPERs To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org Cc: qemu-devel@nongnu.org, jonathan.cameron@huawei.com, mchehab+huawei@kernel.org, gengdongjiu1@gmail.com, mst@redhat.com, imammedo@redhat.com, anisinha@redhat.com, peter.maydell@linaro.org, pbonzini@redhat.com, shan.gavin@gmail.com References: <20251105114453.2164073-1-gshan@redhat.com> <20251105114453.2164073-5-gshan@redhat.com> Content-Language: en-US From: Gavin Shan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=gshan@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Philippe, On 11/11/25 12:43 AM, Philippe Mathieu-Daudé wrote: > On 5/11/25 12:44, Gavin Shan wrote: >> In the situation where host and guest has 64KiB and 4KiB page sizes, >> one problematic host page affects 16 guest pages. we need to send 16 >> consective errors in this specific case. >> >> Extend acpi_ghes_memory_errors() to support multiple CPERs after the >> hunk of code to generate the GHES error status is pulled out from >> ghes_gen_err_data_uncorrectable_recoverable(). The status field of >> generic error status block is also updated accordingly if multiple >> error data entries are contained in the generic error status block. >> >> Signed-off-by: Gavin Shan >> --- >>   hw/acpi/ghes-stub.c    |  2 +- >>   hw/acpi/ghes.c         | 60 +++++++++++++++++++++++------------------- >>   include/hw/acpi/ghes.h |  2 +- >>   target/arm/kvm.c       |  4 ++- >>   4 files changed, 38 insertions(+), 30 deletions(-) > > >>   int acpi_ghes_memory_errors(AcpiGhesState *ags, uint16_t source_id, >> -                            uint64_t physical_address) >> +                            uint64_t *addresses, uint32_t num_of_addresses) >>   { >>       /* Memory Error Section Type */ >>       const uint8_t guid[] = >>             UUID_LE(0xA5BC1114, 0x6F64, 0x4EDE, 0xB8, 0x63, 0x3E, 0x83, \ >>                     0xED, 0x7C, 0x83, 0xB1); >> +    /* >> +     * invalid fru id: ACPI 4.0: 17.3.2.6.1 Generic Error Data, >> +     * Table 17-13 Generic Error Data Entry >> +     */ >> +    QemuUUID fru_id = {}; >>       Error *errp = NULL; >>       int data_length; >>       GArray *block; >> +    uint32_t block_status, i; >>       block = g_array_new(false, true /* clear */, 1); >> -    data_length = ACPI_GHES_DATA_LENGTH + ACPI_GHES_MEM_CPER_LENGTH; >> +    data_length = num_of_addresses * >> +                  (ACPI_GHES_DATA_LENGTH + ACPI_GHES_MEM_CPER_LENGTH); > > Should we check num_of_addresses is in range? > The check is already done by the following assert(). /* * It should not run out of the preallocated memory if adding a new generic * error data entry */ assert((data_length + ACPI_GHES_GESB_SIZE) <= ACPI_GHES_MAX_RAW_DATA_LENGTH); Thanks, Gavin