public inbox for qemu-devel@nongnu.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>
Cc: "Michael Tokarev" <mjt@tls.msk.ru>,
	qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [PATCH v3 00/10] chardev: Improve @docstring and clarify qemu_chr_write() uses
Date: Mon, 23 Mar 2026 10:03:33 +0100	[thread overview]
Message-ID: <dd44fd32-09b6-4c88-ab55-4472d5c4366b@linaro.org> (raw)
In-Reply-To: <CAJ+F1CKkpcYCAnv1YACrnySodumarEQy0Ff-UedWY_Q4u3C7vg@mail.gmail.com>

On 23/3/26 09:45, Marc-André Lureau wrote:
> Hi
> 
> On Mon, Mar 23, 2026 at 6:05 AM Pierrick Bouvier
> <pierrick.bouvier@linaro.org> wrote:
>>
>> On 3/21/26 11:15 PM, Michael Tokarev wrote:
>>> On 12.02.2026 23:13, Philippe Mathieu-Daudé wrote:
>>>
>>>>>>>    From this patchset, 1 change has now found its way to the master
>>>>>>> branch:
>>>>>>>
>>>>>>>     chardev/char-pty: Do not ignore chr_write() failures
>>>>>>>
>>>>>>> Besides it, the following 2 changes were marked for-stable:
>>>>>>>
>>>>>>>     chardev/char: Allow partial writes in qemu_chr_write()
>>>>>>>     chardev/char: Preserve %errno in qemu_chr_write()
>>>>>>>
>>>>>>> Are other changes (including the above 2) not needed anymore?
>>>>>>
>>>>>> They are, I need to reply to Marc-André and respin a v4...
> 
> What was that for?

On patch #6:

   > the final return value that should be changed?
   > "offset && !write_all ? offset : res" ?

> 
>>>>>>
>>>>>> Old bugs so can wait 11.0 :S
>>>>>
>>>>> Found an old(ish) thread...  ping? :))
>>>>
>>>> Cc'ing new docs/ maintainer :P
>>>
>>> Ping *N?  11.0 is almost out already..
>>>
>>> /mjt
>>
>> I didn't answer previously, since it was touching code in addition to
>> docs, and was expecting this to be picked up by chardev maintainer
>> (Marc-André in this case if I'm right). So I assumed it fell back to a
>> subsystem documentation change and not a general one I was supposed to take.
>>
> 
> I think we missed the boat for 11.0.
> 
> Philippe, maybe you can rebase, and I will queue for 11.1?

Maybe, no promise.


      reply	other threads:[~2026-03-23  9:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-12 13:41 [PATCH v3 00/10] chardev: Improve @docstring and clarify qemu_chr_write() uses Philippe Mathieu-Daudé
2025-11-12 13:41 ` [PATCH v3 01/10] chardev/char-fe: Improve @docstrings Philippe Mathieu-Daudé
2025-11-12 13:58   ` Daniel P. Berrangé
2025-11-13 11:31   ` Marc-André Lureau
2025-11-12 13:41 ` [PATCH v3 02/10] chardev/char-io: Add @docstrings for io_channel_send[_full]() Philippe Mathieu-Daudé
2025-11-13 11:32   ` Marc-André Lureau
2025-11-12 13:41 ` [PATCH v3 03/10] chardev/char: Improve ChardevClass::chr_write() docstring Philippe Mathieu-Daudé
2025-11-12 13:41 ` [PATCH v3 04/10] chardev/char: Document qemu_chr_write[_all]() Philippe Mathieu-Daudé
2025-11-12 13:41 ` [PATCH v3 05/10] chardev/char-pty: Do not ignore chr_write() failures Philippe Mathieu-Daudé
2025-11-12 13:41 ` [PATCH v3 06/10] chardev/char: Allow partial writes in qemu_chr_write() Philippe Mathieu-Daudé
2025-11-13 11:30   ` Marc-André Lureau
2025-11-12 13:41 ` [PATCH v3 07/10] chardev/char: Preserve %errno " Philippe Mathieu-Daudé
2025-11-12 13:41 ` [PATCH v3 08/10] chardev/char: Document qemu_chr_fe_write()'s return value Philippe Mathieu-Daudé
2025-11-13 11:32   ` Marc-André Lureau
2025-11-12 13:41 ` [PATCH v3 09/10] hw/char: Simplify when qemu_chr_fe_write() could not write Philippe Mathieu-Daudé
2025-11-12 13:41 ` [PATCH v3 10/10] system/replay: Rename some method parameters Philippe Mathieu-Daudé
2025-11-12 13:44 ` [PATCH v3 00/10] chardev: Improve @docstring and clarify qemu_chr_write() uses Philippe Mathieu-Daudé
2025-11-26  6:56 ` Michael Tokarev
2025-11-26  7:45   ` Philippe Mathieu-Daudé
2026-02-12 17:58     ` Michael Tokarev
2026-02-12 20:13       ` Philippe Mathieu-Daudé
2026-03-22  6:15         ` Michael Tokarev
2026-03-23  2:04           ` Pierrick Bouvier
2026-03-23  8:45             ` Marc-André Lureau
2026-03-23  9:03               ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd44fd32-09b6-4c88-ab55-4472d5c4366b@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=marcandre.lureau@gmail.com \
    --cc=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox