From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biOdT-0005MF-RL for qemu-devel@nongnu.org; Fri, 09 Sep 2016 12:26:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1biOdO-0006e0-QR for qemu-devel@nongnu.org; Fri, 09 Sep 2016 12:26:39 -0400 Received: from mail-pa0-x242.google.com ([2607:f8b0:400e:c03::242]:33799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biOdO-0006dm-Jb for qemu-devel@nongnu.org; Fri, 09 Sep 2016 12:26:34 -0400 Received: by mail-pa0-x242.google.com with SMTP id gi6so4057332pac.1 for ; Fri, 09 Sep 2016 09:26:34 -0700 (PDT) Sender: Richard Henderson References: <1472935202-3342-1-git-send-email-rth@twiddle.net> <1472935202-3342-14-git-send-email-rth@twiddle.net> <20160909144616.GA6795@hhmipssw201.hh.imgtec.org> From: Richard Henderson Message-ID: Date: Fri, 9 Sep 2016 09:26:29 -0700 MIME-Version: 1.0 In-Reply-To: <20160909144616.GA6795@hhmipssw201.hh.imgtec.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leon Alrae Cc: "qemu-devel@nongnu.org" On 09/09/2016 07:46 AM, Leon Alrae wrote: > Wouldn't it be useful if tcg.h provided also aliases for _le/_be atomic > helpers (equivalent to helper_ret_X_mmu) so that in target-* code we wouldn't > need to care about the endianness (specifically I'm thinking about SC in MIPS > where I need to select between helper_atomic_cmpxchgl_le_mmu() and > helper_atomic_cmpxchgl_be_mmu()). Perhaps. I would have hoped that you could do the SC inline now though, and tcg_gen_atomic_cmpxchg() will do the selection for you. r~